Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1481753003: [compiler] Decouple ToObject from CreateWithContext. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Decouple ToObject from CreateWithContext. Decouple the implicit ToObject for with statements from the actual creation of the with context. This way we can handle/optimize those constructs separately. R=mstarzinger@chromium.org Committed: https://crrev.com/e3a46bc766a97d7070f02f1fda67af335e575e84 Cr-Commit-Position: refs/heads/master@{#32341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -43 lines) Patch
M src/ast.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +19 lines, -27 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -6 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-11-26 14:02:58 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline. Straight-forward awesomeness :-) Please take a look. Thanks, Benedikt
5 years ago (2015-11-26 14:03:34 UTC) #2
Michael Starzinger
LGTM.
5 years ago (2015-11-26 14:20:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481753003/1
5 years ago (2015-11-26 14:20:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 14:29:39 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-26 14:30:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3a46bc766a97d7070f02f1fda67af335e575e84
Cr-Commit-Position: refs/heads/master@{#32341}

Powered by Google App Engine
This is Rietveld 408576698