Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1481753002: ServiceWorker: Enable WindowClient.navigate() method by default. (Closed)

Created:
5 years ago by zino
Modified:
5 years ago
Reviewers:
tkent, falken, jungkees, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Enable WindowClient.navigate() method by default. Enable WindowClient.navigate() method by default. Intent to ship: http://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/21YdGHt2ogM Spec: http://slightlyoff.github.io/ServiceWorker/spec/service_worker/#client-navigate BUG=500911 Committed: https://crrev.com/ee1a4f22a370d13d746af1c78aecde6f67f16988 Cr-Commit-Position: refs/heads/master@{#363473}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
zino
Please take a look. Thank you.
5 years ago (2015-12-04 19:48:49 UTC) #6
tkent
lgtm
5 years ago (2015-12-06 22:50:21 UTC) #7
nhiroki
LGTM after the other CL[1] is landed. (Could you add a test case for in-scope-but-not-controlled-client[2] ...
5 years ago (2015-12-07 00:29:29 UTC) #8
zino
On 2015/12/07 00:29:29, nhiroki wrote: > LGTM after the other CL[1] is landed. > > ...
5 years ago (2015-12-07 10:54:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481753002/1
5 years ago (2015-12-07 10:55:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/145270)
5 years ago (2015-12-07 12:00:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481753002/40001
5 years ago (2015-12-07 12:33:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-07 14:13:28 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-07 14:14:18 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee1a4f22a370d13d746af1c78aecde6f67f16988
Cr-Commit-Position: refs/heads/master@{#363473}

Powered by Google App Engine
This is Rietveld 408576698