Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

Issue 148173018: [SVG] SVGAnimatedString{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove debug print Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFilterPrimitiveStandardAttributes.h ('k') | Source/core/svg/SVGFontFaceUriElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
diff --git a/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp b/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
index b41bba04ade5b7ae20207ec296c6e3ce7fb32560..dd5cbd72fd97dd2a06ebdde11694474173d7102e 100644
--- a/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
+++ b/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
@@ -32,10 +32,8 @@
namespace WebCore {
// Animated property definitions
-DEFINE_ANIMATED_STRING(SVGFilterPrimitiveStandardAttributes, SVGNames::resultAttr, Result, result)
BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGFilterPrimitiveStandardAttributes)
- REGISTER_LOCAL_ANIMATED_PROPERTY(result)
REGISTER_PARENT_ANIMATED_PROPERTIES(SVGElement)
END_REGISTER_ANIMATED_PROPERTIES
@@ -45,6 +43,7 @@ SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes(const
, m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(LengthModeHeight)))
, m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(LengthModeWidth)))
, m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(LengthModeHeight)))
+ , m_result(SVGAnimatedString::create(this, SVGNames::resultAttr, SVGString::create()))
{
// Spec: If the x/y attribute is not specified, the effect is as if a value of "0%" were specified.
m_x->setDefaultValueAsString("0%");
@@ -58,6 +57,7 @@ SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes(const
addToPropertyMap(m_y);
addToPropertyMap(m_width);
addToPropertyMap(m_height);
+ addToPropertyMap(m_result);
registerAnimatedPropertiesForSVGFilterPrimitiveStandardAttributes();
}
@@ -89,7 +89,7 @@ void SVGFilterPrimitiveStandardAttributes::parseAttribute(const QualifiedName& n
else if (name == SVGNames::heightAttr)
m_height->setBaseValueAsString(value, ForbidNegativeLengths, parseError);
else if (name == SVGNames::resultAttr)
- setResultBaseValue(value);
+ m_result->setBaseValueAsString(value, parseError);
else
ASSERT_NOT_REACHED();
« no previous file with comments | « Source/core/svg/SVGFilterPrimitiveStandardAttributes.h ('k') | Source/core/svg/SVGFontFaceUriElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698