Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: Source/core/svg/SVGFEDropShadowElement.cpp

Issue 148173018: [SVG] SVGAnimatedString{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove debug print Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFEDropShadowElement.h ('k') | Source/core/svg/SVGFEGaussianBlurElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFEDropShadowElement.cpp
diff --git a/Source/core/svg/SVGFEDropShadowElement.cpp b/Source/core/svg/SVGFEDropShadowElement.cpp
index 98c632a955b361c006835386061b83bd4eeae444..5d219c5054ddb135f56b9ca2c15346346460d3ff 100644
--- a/Source/core/svg/SVGFEDropShadowElement.cpp
+++ b/Source/core/svg/SVGFEDropShadowElement.cpp
@@ -31,10 +31,8 @@
namespace WebCore {
// Animated property definitions
-DEFINE_ANIMATED_STRING(SVGFEDropShadowElement, SVGNames::inAttr, In1, in1)
BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGFEDropShadowElement)
- REGISTER_LOCAL_ANIMATED_PROPERTY(in1)
REGISTER_PARENT_ANIMATED_PROPERTIES(SVGFilterPrimitiveStandardAttributes)
END_REGISTER_ANIMATED_PROPERTIES
@@ -43,12 +41,14 @@ inline SVGFEDropShadowElement::SVGFEDropShadowElement(Document& document)
, m_dx(SVGAnimatedNumber::create(this, SVGNames::dxAttr, SVGNumber::create(2)))
, m_dy(SVGAnimatedNumber::create(this, SVGNames::dyAttr, SVGNumber::create(2)))
, m_stdDeviation(SVGAnimatedNumberOptionalNumber::create(this, SVGNames::stdDeviationAttr, 2, 2))
+ , m_in1(SVGAnimatedString::create(this, SVGNames::inAttr, SVGString::create()))
{
ScriptWrappable::init(this);
addToPropertyMap(m_dx);
addToPropertyMap(m_dy);
addToPropertyMap(m_stdDeviation);
+ addToPropertyMap(m_in1);
registerAnimatedPropertiesForSVGFEDropShadowElement();
}
@@ -83,14 +83,11 @@ void SVGFEDropShadowElement::parseAttribute(const QualifiedName& name, const Ato
return;
}
- if (name == SVGNames::inAttr) {
- setIn1BaseValue(value);
- return;
- }
-
SVGParsingError parseError = NoError;
- if (name == SVGNames::dxAttr)
+ if (name == SVGNames::inAttr)
+ m_in1->setBaseValueAsString(value, parseError);
+ else if (name == SVGNames::dxAttr)
m_dx->setBaseValueAsString(value, parseError);
else if (name == SVGNames::dyAttr)
m_dy->setBaseValueAsString(value, parseError);
@@ -137,7 +134,7 @@ PassRefPtr<FilterEffect> SVGFEDropShadowElement::build(SVGFilterBuilder* filterB
Color color = svgStyle->floodColor();
float opacity = svgStyle->floodOpacity();
- FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentValue()));
+ FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->currentValue()->value()));
if (!input1)
return 0;
« no previous file with comments | « Source/core/svg/SVGFEDropShadowElement.h ('k') | Source/core/svg/SVGFEGaussianBlurElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698