Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: Source/core/svg/SVGFEComponentTransferElement.cpp

Issue 148173018: [SVG] SVGAnimatedString{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove debug print Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFEComponentTransferElement.h ('k') | Source/core/svg/SVGFECompositeElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFEComponentTransferElement.cpp
diff --git a/Source/core/svg/SVGFEComponentTransferElement.cpp b/Source/core/svg/SVGFEComponentTransferElement.cpp
index 653ee00b640195c7e4f1d805a285e08d58c9a32c..89cc6ea20ac179b52b8262c3129e2825be5dbb8c 100644
--- a/Source/core/svg/SVGFEComponentTransferElement.cpp
+++ b/Source/core/svg/SVGFEComponentTransferElement.cpp
@@ -33,17 +33,17 @@
namespace WebCore {
// Animated property definitions
-DEFINE_ANIMATED_STRING(SVGFEComponentTransferElement, SVGNames::inAttr, In1, in1)
BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGFEComponentTransferElement)
- REGISTER_LOCAL_ANIMATED_PROPERTY(in1)
REGISTER_PARENT_ANIMATED_PROPERTIES(SVGFilterPrimitiveStandardAttributes)
END_REGISTER_ANIMATED_PROPERTIES
inline SVGFEComponentTransferElement::SVGFEComponentTransferElement(Document& document)
: SVGFilterPrimitiveStandardAttributes(SVGNames::feComponentTransferTag, document)
+ , m_in1(SVGAnimatedString::create(this, SVGNames::inAttr, SVGString::create()))
{
ScriptWrappable::init(this);
+ addToPropertyMap(m_in1);
registerAnimatedPropertiesForSVGFEComponentTransferElement();
}
@@ -67,17 +67,19 @@ void SVGFEComponentTransferElement::parseAttribute(const QualifiedName& name, co
return;
}
- if (name == SVGNames::inAttr) {
- setIn1BaseValue(value);
- return;
- }
+ SVGParsingError parseError = NoError;
+
+ if (name == SVGNames::inAttr)
+ m_in1->setBaseValueAsString(value, parseError);
+ else
+ ASSERT_NOT_REACHED();
- ASSERT_NOT_REACHED();
+ reportAttributeParsingError(parseError, name, value);
}
PassRefPtr<FilterEffect> SVGFEComponentTransferElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)
{
- FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentValue()));
+ FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->currentValue()->value()));
if (!input1)
return 0;
« no previous file with comments | « Source/core/svg/SVGFEComponentTransferElement.h ('k') | Source/core/svg/SVGFECompositeElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698