Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp

Issue 148173018: [SVG] SVGAnimatedString{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove debug print Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimateElement.h ('k') | Source/core/svg/SVGAnimatedString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
diff --git a/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp b/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
index 114df8ba02e93dccff223abc4aaab209dabff282..ef497756bfe17eed479d22caa0729e69a75cb769 100644
--- a/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
+++ b/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
@@ -38,6 +38,7 @@
#include "core/svg/SVGLengthList.h"
#include "core/svg/SVGNumber.h"
#include "core/svg/SVGPointList.h"
+#include "core/svg/SVGString.h"
namespace WebCore {
@@ -90,6 +91,11 @@ PassRefPtr<NewSVGPropertyBase> SVGAnimatedNewPropertyAnimator::createPropertyFor
property->setValueAsString(value, IGNORE_EXCEPTION);
return property.release();
}
+ case AnimatedString: {
+ RefPtr<SVGString> property = SVGString::create();
+ property->setValueAsString(value, IGNORE_EXCEPTION);
+ return property.release();
+ }
// These types don't appear in the table in SVGElement::cssPropertyToTypeMap() and thus don't need support.
case AnimatedBoolean:
@@ -107,7 +113,7 @@ PassRefPtr<NewSVGPropertyBase> SVGAnimatedNewPropertyAnimator::createPropertyFor
case AnimatedIntegerOptionalInteger:
case AnimatedPath:
case AnimatedPreserveAspectRatio:
- case AnimatedString:
+ case AnimatedStringList:
case AnimatedTransformList:
ASSERT_NOT_REACHED();
« no previous file with comments | « Source/core/svg/SVGAnimateElement.h ('k') | Source/core/svg/SVGAnimatedString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698