[SVG] SVGAnimatedString{,List} migration to new SVG property impl.

Source/core/svg/SVGGlyphRefElement.cpp

 /*
  * Copyright (C) 2011 Leo Yang <leoyang@webkit.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
 #if ENABLE(SVG_FONTS)
 #include "core/svg/SVGGlyphRefElement.h"
 
 #include "XLinkNames.h"
 #include "core/svg/SVGParserUtilities.h"
 #include "wtf/text/AtomicString.h"
 
 namespace WebCore {
 
 // Animated property definitions
-DEFINE_ANIMATED_STRING(SVGGlyphRefElement, XLinkNames::hrefAttr, Href, href)
 
 BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGGlyphRefElement)
-    REGISTER_LOCAL_ANIMATED_PROPERTY(href)
     REGISTER_PARENT_ANIMATED_PROPERTIES(SVGElement)
 END_REGISTER_ANIMATED_PROPERTIES
 
 inline SVGGlyphRefElement::SVGGlyphRefElement(Document& document)
     : SVGElement(SVGNames::glyphRefTag, document)
+    , m_href(SVGAnimatedString::create(this, XLinkNames::hrefAttr, SVGString::create()))
     , m_x(0)
     , m_y(0)
     , m_dx(0)
     , m_dy(0)
 {
     ScriptWrappable::init(this);
+    addToPropertyMap(m_href);
     registerAnimatedPropertiesForSVGGlyphRefElement();
 }
 
 PassRefPtr<SVGGlyphRefElement> SVGGlyphRefElement::create(Document& document)
 {
     return adoptRef(new SVGGlyphRefElement(document));
 }
 
 bool SVGGlyphRefElement::hasValidGlyphElement(AtomicString& glyphName) const
 {
     // FIXME: We only support xlink:href so far.
     // https://bugs.webkit.org/show_bug.cgi?id=64787
     Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefAttr), document(), &glyphName);
     if (!element || !element->hasTagName(SVGNames::glyphTag))
         return false;
     return true;
 }
 
 template<typename CharType>
 void SVGGlyphRefElement::parseAttributeInternal(const QualifiedName& name, const AtomicString& value)
 {
     const CharType* ptr = value.isEmpty() ? 0 : value.string().getCharacters<CharType>();
     const CharType* end = ptr + value.length();
 
     // FIXME: We need some error handling here.

[haraken, 2014/01/29 05:18:00]

What does this FIXME imply? I wonder why this code doesn't have the following
pattern:

SVGParsingError parseError = NoError;
if (...)
  ...;
else if (...)
  ...;
else
  ASSERT_NOT_REACHED();

reportAttributeParsingError(parseError, name, value);

[kouhei (in TOK), 2014/01/30 08:18:56]

I will do that when I land SVGNumber{,List} migration CL. I'd like to keep as
this is in this CL.

     if (name == SVGNames::xAttr) {
         parseNumber(ptr, end, m_x);
     } else if (name == SVGNames::yAttr) {
         parseNumber(ptr, end, m_y);
     } else if (name == SVGNames::dxAttr) {
         parseNumber(ptr, end, m_dx);
     } else if (name == SVGNames::dyAttr) {
         parseNumber(ptr, end, m_dy);
+    } else if (name.matches(XLinkNames::hrefAttr)) {
+        SVGParsingError parseError = NoError;
+        m_href->setBaseValueAsString(value, parseError);
+        reportAttributeParsingError(parseError, name, value);
     } else {
-        if (SVGURIReference::parseAttribute(name, value))
-            return;
         SVGElement::parseAttribute(name, value);
     }
 }
 
 void SVGGlyphRefElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (value.isEmpty() || value.is8Bit())
         parseAttributeInternal<LChar>(name, value);
     else
         parseAttributeInternal<UChar>(name, value);
@@ skipping 34 matching lines @@
 void SVGGlyphRefElement::setDy(float dy)
 {
     // FIXME: Honor attribute change.
     // https://bugs.webkit.org/show_bug.cgi?id=64787
     m_dy = dy;
 }
 
 }
 
 #endif