Issue 148173014: Use WorkspaceLayoutManager for AlwaysOnTop and Lock containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148173014: Use WorkspaceLayoutManager for AlwaysOnTop and Lock containers (Closed)

Created:
6 years, 10 months ago by oshima

Modified:
6 years, 10 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use WorkspaceLayoutManager for AlwaysOnTop and Lock containers BUG=338906 TEST=Tested on the device and confirmed that login/lock screens are fine. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247733

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	ash/root_window_controller.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

oshima

I believe this is fine, but I'd wait for a week before merging and renaming ...

6 years, 10 months ago (2014-01-29 01:51:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/148173014/1

6 years, 10 months ago (2014-01-29 06:00:53 UTC) #3

commit-bot: I haz the power

Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=42990

6 years, 10 months ago (2014-01-29 16:04:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/148173014/1

6 years, 10 months ago (2014-01-29 17:45:24 UTC) #5

Message was sent while issue was closed.

Change committed as 247733

Expand Messages | Collapse Messages