Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148173010: Revert of Add --skip_cpu and --skip_gpu options to tests (Closed)

Created:
6 years, 10 months ago by borenet
Modified:
6 years, 10 months ago
Reviewers:
djsollen, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Add --skip_cpu and --skip_gpu options to tests (https://codereview.chromium.org/144343004/) Reason for revert: Broke tests on Win7 and Mac Original issue's description: > Add --skip_cpu and --skip_gpu options to tests > > BUG=skia:2074 > > Committed: http://code.google.com/p/skia/source/detail?r=13223 TBR=djsollen@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2074 Committed: http://code.google.com/p/skia/source/detail?r=13224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M tests/Test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/skia_test.cpp View 4 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
borenet
Created Revert of Add --skip_cpu and --skip_gpu options to tests
6 years, 10 months ago (2014-01-28 20:21:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/148173010/1
6 years, 10 months ago (2014-01-28 20:21:16 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 20:21:26 UTC) #3
Message was sent while issue was closed. 
Change committed as 13224

Powered by Google App Engine
This is Rietveld 408576698