win: Move Crashpad all into chrome.exe

chrome/app/chrome_crash_reporter_client.cc

Index: chrome/app/chrome_crash_reporter_client.cc
diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc
index 2663a08017ad0aef4a048deeffd8eb441465f9f1..3f88af7bf56baa0293f594b19185f7327bb96821 100644
--- a/chrome/app/chrome_crash_reporter_client.cc
+++ b/chrome/app/chrome_crash_reporter_client.cc
@@ -16,6 +16,7 @@
 #include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/env_vars.h"
+#include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/public/common/content_switches.h"
 
@@ -278,6 +279,20 @@ base::FilePath ChromeCrashReporterClient::GetReporterLogFilename() {
 
 bool ChromeCrashReporterClient::GetCrashDumpLocation(
     base::FilePath* crash_dir) {
+#if defined(OS_WIN)
+  // In order to be able to start crash handling very early, we do not rely on
+  // the chrome's PathService entries (for DIR_CRASH_DUMPS) being available on

[Mark Mentovai, 2015/12/03 15:11:32]

Lose “the”.

[scottmg, 2015/12/03 18:14:51]

Done.

+  // Windows. See http://crbug.com/564398.
+  base::FilePath result;
+  if (!PathService::Get(base::DIR_LOCAL_APP_DATA, &result))

[Mark Mentovai, 2015/12/03 15:11:32]

Following up on the --user-data-dir discussion:

The DIR_CRASH_DUMPS getter comes with this comment:
which becomes moot if you honor --user-data-dir here.

You can leave it as-is for now and we can save the change for a follow-up fix,
but now that we’ve got a distinct but equivalent way to get DIR_CRASH_DUMPS, the
rationale for not respecting --user-data-dir is shaky.

My main concern is that Chrome treats the consent bit as per-user-data-dir, but
if multiple user-data-dirs share the same Crashpad settings database, things can
easily get out of sync.

It looks like we have this problem on Mac now too, so maybe it’s best to save it
for a follow-up fix after all.

[scottmg, 2015/12/03 18:14:51]

Yeah, that's a good point. I filed crbug.com/565466, and tagged this location
and DIR_CRASH_DUMPS with the bug, but didn't change anything for now.

I don't think anything outside of //components/crash actually needs
DIR_CRASH_DUMPS when using Crashpad, so for Mac and Win we could just make the
canonical location GetCrashDumpLocation() and not support DIR_CRASH_DUMPS at
all.

+    return false;
+  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
+  result = result.Append(dist->GetInstallSubDir());
+  result = result.Append(chrome::kUserDataDirname);
+  result = result.Append(FILE_PATH_LITERAL("Crashpad"));
+  *crash_dir = result;
+  return true;
+#else
   // By setting the BREAKPAD_DUMP_LOCATION environment variable, an alternate
   // location to write breakpad crash dumps can be set.
   scoped_ptr<base::Environment> env(base::Environment::Create());
@@ -289,6 +304,7 @@ bool ChromeCrashReporterClient::GetCrashDumpLocation(
   }
 
   return PathService::Get(chrome::DIR_CRASH_DUMPS, crash_dir);
+#endif
 }
 
 size_t ChromeCrashReporterClient::RegisterCrashKeys() {