win: Move Crashpad all into chrome.exe

chrome/app/chrome_crash_reporter_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_crash_reporter_client.h"
 
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/env_vars.h"
+#include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/public/common/content_switches.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 
 #include "base/file_version_info.h"
 #include "base/win/registry.h"
 #include "chrome/installer/util/google_chrome_sxs_distribution.h"
 #include "chrome/installer/util/install_util.h"
@@ skipping 242 matching lines @@
   *version = PRODUCT_VERSION;
 }
 
 base::FilePath ChromeCrashReporterClient::GetReporterLogFilename() {
   return base::FilePath(CrashUploadList::kReporterLogFilename);
 }
 #endif
 
 bool ChromeCrashReporterClient::GetCrashDumpLocation(
     base::FilePath* crash_dir) {
+#if defined(OS_WIN)
+  // In order to be able to start crash handling very early, we do not rely on
+  // chrome's PathService entries (for DIR_CRASH_DUMPS) being available on
+  // Windows. See http://crbug.com/564398.
+  base::FilePath result;
+  if (!PathService::Get(base::DIR_LOCAL_APP_DATA, &result))
+    return false;
+  BrowserDistribution* dist = BrowserDistribution::GetDistribution();

[cpu_(ooo_6.6-7.5), 2015/12/03 20:53:27]

no need for delete dist; ?

also, are you trying to do the same as chrome/installer/util/helper.cc ?

[scottmg, 2015/12/03 21:06:22]

The code's a bit weird, but I don't think so.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/u...
It makes it into a global and then expects that to stick around.
I didn't even see that one! This is an inline implementation of
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro....

+  result = result.Append(dist->GetInstallSubDir());
+  // TODO(scottmg): Consider supporting --user-data-dir. See
+  // http://crbug.com/565466.

[Mark Mentovai, 2015/12/03 20:35:42]

Wrong bug number (466 v. 446). Also, you should use https for links when it
works, line 285 too.

[scottmg, 2015/12/03 20:52:52]

Oops. I swear https didn't work with crbug.com before, but it seems to now. Done
and done.

+  result = result.Append(chrome::kUserDataDirname);
+  result = result.Append(FILE_PATH_LITERAL("Crashpad"));
+  *crash_dir = result;
+  return true;
+#else
   // By setting the BREAKPAD_DUMP_LOCATION environment variable, an alternate
   // location to write breakpad crash dumps can be set.
   scoped_ptr<base::Environment> env(base::Environment::Create());
   std::string alternate_crash_dump_location;
   if (env->GetVar("BREAKPAD_DUMP_LOCATION", &alternate_crash_dump_location)) {
     base::FilePath crash_dumps_dir_path =
         base::FilePath::FromUTF8Unsafe(alternate_crash_dump_location);
     PathService::Override(chrome::DIR_CRASH_DUMPS, crash_dumps_dir_path);
   }
 
   return PathService::Get(chrome::DIR_CRASH_DUMPS, crash_dir);
+#endif
 }
 
 size_t ChromeCrashReporterClient::RegisterCrashKeys() {
   return crash_keys::RegisterChromeCrashKeys();
 }
 
 bool ChromeCrashReporterClient::IsRunningUnattended() {
   scoped_ptr<base::Environment> env(base::Environment::Create());
   return env->HasVar(env_vars::kHeadless);
 }
@@ skipping 33 matching lines @@
 #endif
 
 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return process_type == switches::kRendererProcess ||
          process_type == switches::kPluginProcess ||
          process_type == switches::kPpapiPluginProcess ||
          process_type == switches::kZygoteProcess ||
          process_type == switches::kGpuProcess;
 }