win: Move Crashpad all into chrome.exe

chrome/app/chrome_exe_main_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <malloc.h>
 #include <shellscalingapi.h>
 #include <tchar.h>
 
 #include <algorithm>
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
+#include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/win/windows_version.h"
+#include "chrome/app/chrome_crash_reporter_client.h"
 #include "chrome/app/main_dll_loader_win.h"
 #include "chrome/browser/chrome_process_finder_win.h"
 #include "chrome/browser/policy/policy_path_parser.h"
+#include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome_elf/chrome_elf_main.h"
+#include "components/crash/content/app/crash_reporter_client.h"
+#include "components/crash/content/app/crashpad.h"
 #include "components/startup_metric_utils/browser/startup_metric_utils.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/result_codes.h"
 #include "third_party/crashpad/crashpad/handler/handler_main.h"
 #include "ui/gfx/win/dpi.h"
 
 namespace {
+
+base::LazyInstance<ChromeCrashReporterClient>::Leaky g_chrome_crash_client =
+    LAZY_INSTANCE_INITIALIZER;
+
 // List of switches that it's safe to rendezvous early with. Fast start should
 // not be done if a command line contains a switch not in this set.
 // Note this is currently stored as a list of two because it's probably faster
 // to iterate over this small array than building a map for constant time
 // lookups.
 const char* const kFastStartSwitches[] = {
   switches::kProfileDirectory,
   switches::kShowAppList,
 };
 
@@ skipping 75 matching lines @@
   // Only needed on XP but harmless on other Windows flavors.
   auto crt_heap = _get_heap_handle();
   ULONG enable_LFH = 2;
   if (HeapSetInformation(reinterpret_cast<HANDLE>(crt_heap),
                          HeapCompatibilityInformation,
                          &enable_LFH, sizeof(enable_LFH))) {
     VLOG(1) << "Low fragmentation heap enabled.";
   }
 }
 
-bool RunAsCrashpadHandler(wchar_t* command_line, int* rc) {
-  const base::CommandLine cmdline = base::CommandLine::FromString(command_line);
-  if (cmdline.GetSwitchValueASCII(switches::kProcessType) ==
-      switches::kCrashpadHandler) {
-    std::vector<base::string16> argv = cmdline.argv();
-    base::string16 process_type =
-        L"--" + base::UTF8ToUTF16(switches::kProcessType) + L"=";
-    argv.erase(std::remove_if(argv.begin(), argv.end(),
-                              [&process_type](const base::string16& str) {
-                                return str.compare(0, process_type.size(),
-                                                   process_type) == 0;
-                              }),
-               argv.end());
+int RunAsCrashpadHandler(const base::CommandLine& command_line) {
+  DCHECK_EQ(command_line.GetSwitchValueASCII(switches::kProcessType),

[cpu_(ooo_6.6-7.5), 2015/12/02 19:12:26]

I don't know if we can use dchecks here since the logger stuff is initialized in
the dll. Or rather there was a conflict with the two loggers. I asked Bruce to
look into this so he might have the best guess at what is going to happen.

[scottmg, 2015/12/02 21:57:29]

Oh good point. It's definitely not initialized at this point, so I guess it'll
do something weird if it fails. It's only checking the code immediately before
this function was called, so I just removed it.

[Mark Mentovai, 2015/12/02 22:01:04]

scottmg wrote:
There are DCHECKs that might get hit in HandlerMain() too, though. Uh-oh.

[scottmg, 2015/12/02 22:28:28]

In practice in a debug build on Windows, it logs to stderr and debug.log and
then __debugbreak()s. So it's a little confusing because you never see a window,
but not too bad. So I could probably put the DCHECK back in here, but it also
wasn't that useful.

+            switches::kCrashpadHandler);
+  std::vector<base::string16> argv = command_line.argv();
+  base::string16 process_type =
+      L"--" + base::UTF8ToUTF16(switches::kProcessType) + L"=";
+  argv.erase(std::remove_if(argv.begin(), argv.end(),
+                            [&process_type](const base::string16& str) {
+                              return str.compare(0, process_type.size(),
+                                                 process_type) == 0;
+                            }),
+             argv.end());
 
-    scoped_ptr<char* []> argv_as_utf8(new char*[argv.size() + 1]);
-    std::vector<std::string> storage;
-    storage.reserve(argv.size());
-    for (size_t i = 0; i < argv.size(); ++i) {
-      storage.push_back(base::UTF16ToUTF8(argv[i]));
-      argv_as_utf8[i] = &storage[i][0];
-    }
-    argv_as_utf8[argv.size()] = nullptr;
-    *rc = crashpad::HandlerMain(static_cast<int>(argv.size()),
-                                argv_as_utf8.get());
-    return true;
+  scoped_ptr<char* []> argv_as_utf8(new char*[argv.size() + 1]);
+  std::vector<std::string> storage;
+  storage.reserve(argv.size());
+  for (size_t i = 0; i < argv.size(); ++i) {
+    storage.push_back(base::UTF16ToUTF8(argv[i]));
+    argv_as_utf8[i] = &storage[i][0];
   }
-  return false;
+  argv_as_utf8[argv.size()] = nullptr;

[cpu_(ooo_6.6-7.5), 2015/12/02 19:12:26]

the above reads funny, as if you are zeroing one-past the end ... are you?

[scottmg, 2015/12/02 21:57:29]

Yeah, it looks funny, but I think it's OK. It's allocated one larger on line
150. The getopt library that we use in crashpad isn't so awesome and seems to
rely on the argv[argc] = null.

+  return crashpad::HandlerMain(static_cast<int>(argv.size()),
+                               argv_as_utf8.get());
 }
 
 }  // namespace
 
+// This helper is looked up in the browser to retrieve the crash reports. See
+// CrashUploadListCrashpad.
+extern "C" __declspec(dllexport) void GetUploadedReportsImpl(
+    std::vector<crash_reporter::UploadedReport>* uploaded_reports) {

[Mark Mentovai, 2015/12/02 14:59:23]

Is there also precedent for moving C++ types across module boundaries? Do
chrome.exe and chrome.dll share the same C++ standard library/CRT?

[cpu_(ooo_6.6-7.5), 2015/12/02 19:12:26]

This is somewhat safe as long as there is no exe and dll mismatch, that is
chrome N exe loading chrome N+1 dll, however I believe that issue still exists
on the field. There is even a chromecash/ bucket for it.  

Chrome exe and chrome dll share the sanbox C++ interface but that is pure
virtual, which will be also the safest choice here

class UploadedReports {
   virtual X* GetNext() = 0;
   virtual void Reset() = 0;
};

Something like that could work, assuming that we only want to read reports.
Mutating the std vector will be a no-no across binaries.

[scottmg, 2015/12/02 21:57:29]

Since I need to store the returned list in the exe then anyway, I just had the
helper function return a pointer and a count.

+  crash_reporter::GetUploadedReports(uploaded_reports);
+}
+
 #if !defined(WIN_CONSOLE_APP)
 int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE prev, wchar_t*, int) {
 #else
 int main() {
-  HINSTANCE instance = GetModuleHandle(NULL);
+  HINSTANCE instance = GetModuleHandle(nullptr);
 #endif
-  int rc;
-  if (RunAsCrashpadHandler(GetCommandLine(), &rc))
-    return rc;
+  // Initialize the CommandLine singleton from the environment.
+  base::CommandLine::Init(0, nullptr);
+
+  // The exit manager is in charge of calling the dtors of singletons.
+  base::AtExitManager exit_manager;
+
+  std::string process_type =
+      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+          switches::kProcessType);
+
+  if (process_type == switches::kCrashpadHandler)
+    return RunAsCrashpadHandler(*base::CommandLine::ForCurrentProcess());
+
+  // TODO(scottmg): This and the AtExitManager above are required so the crash
+  // reporter knows where to store its dumps. We could potentially avoid this by
+  // modifying ChromeCrashReporterClient to do that somehow else more manually
+  // on Windows. https://code.google.com/p/chromium/issues/detail?id=564398.

[cpu_(ooo_6.6-7.5), 2015/12/02 19:12:26]

yeah, once you start using the path providers you pretty much stuck with the
AEM. I don't imagine is worth fighting that fight.

[scottmg, 2015/12/02 21:57:29]

The whole thing is kind of a pain. I'm not really sure why PathService needs a
LazyInstance, or why that needs an AtExitManager anyway (couldn't it just leak
the path data?)

But it was also a pain to get the delicate initialization order right in all the
different test binaries (different for chrome vs. content), so I went for it,
since it's also a bit less code running here before we get registered.

We end up needing %LOCALAPPDATA%, the exe path, module path, and %PROGRAMFILES%
so I made standalone functions for those in base_paths_win.

Too ugly or OK?

+  chrome::RegisterPathProvider();
+
+  crash_reporter::SetCrashReporterClient(g_chrome_crash_client.Pointer());
+  crash_reporter::InitializeCrashpad(process_type.empty(), process_type);
 
   SwitchToLFHeap();
 
   startup_metric_utils::RecordExeMainEntryPointTime(base::Time::Now());
 
   // Signal Chrome Elf that Chrome has begun to start.
   SignalChromeElf();
 
-  // Initialize the commandline singleton from the environment.
-  base::CommandLine::Init(0, NULL);
-  // The exit manager is in charge of calling the dtors of singletons.
-  base::AtExitManager exit_manager;
-
   // We don't want to set DPI awareness on pre-Win7 because we don't support
   // DirectWrite there. GDI fonts are kerned very badly, so better to leave
   // DPI-unaware and at effective 1.0. See also ShouldUseDirectWrite().
   if (base::win::GetVersion() >= base::win::VERSION_WIN7)
     EnableHighDPISupport();
 
   if (AttemptFastNotify(*base::CommandLine::ForCurrentProcess()))
     return 0;
 
   // Load and launch the chrome dll. *Everything* happens inside.
   VLOG(1) << "About to load main DLL.";
   MainDllLoader* loader = MakeMainDllLoader();
-  rc = loader->Launch(instance);
+  int rc = loader->Launch(instance);
   loader->RelaunchChromeBrowserWithNewCommandLineIfNeeded();
   delete loader;
   return rc;
 }