win: Move Crashpad all into chrome.exe

chrome/browser/crash_upload_list_crashpad.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/crash_upload_list_crashpad.h"
 
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/time/time.h"
+#include "chrome/common/chrome_constants.h"
 #include "components/crash/content/app/crashpad.h"
 
+namespace {
+
+#if defined(OS_WIN)
+typedef void (*GetUploadedReportsPointer)(
+    std::vector<crash_reporter::UploadedReport>*);
+
+void GetUploadedReportsThunk(

[Mark Mentovai, 2015/12/02 03:05:07]

:/

[scottmg, 2015/12/02 05:35:00]

Yeah, it's icky. But not unprecedented as I learned today, sadly.

+    std::vector<crash_reporter::UploadedReport>* uploaded_reports) {
+  static GetUploadedReportsPointer get_uploaded_reports = nullptr;

[Mark Mentovai, 2015/12/02 03:05:07]

Too bad we don’t have GET_FUNCTION() here.

[scottmg, 2015/12/02 05:35:00]

Yeah, we should probably add that to base.

+  if (!get_uploaded_reports) {
+    HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
+    if (!exe_module)
+      return;
+    get_uploaded_reports = reinterpret_cast<GetUploadedReportsPointer>(
+        GetProcAddress(exe_module, "GetUploadedReportsImpl"));
+  }
+
+  if (get_uploaded_reports)
+    get_uploaded_reports(uploaded_reports);
+}
+#endif  // OS_WIN
+
+}  // namespace
+
 CrashUploadListCrashpad::CrashUploadListCrashpad(
     Delegate* delegate,
     const base::FilePath& upload_log_path,
     const scoped_refptr<base::SequencedWorkerPool>& worker_pool)
     : CrashUploadList(delegate, upload_log_path, worker_pool) {}
 
 CrashUploadListCrashpad::~CrashUploadListCrashpad() {}
 
 void CrashUploadListCrashpad::LoadUploadList() {
   std::vector<crash_reporter::UploadedReport> uploaded_reports;
+#if defined(OS_WIN)
+  // On Windows, we only link crash client into chrome.exe (not the dlls), and
+  // it does the registration. That means the global that holds the crash report
+  // database lives in the .exe, so we need to grab a pointer to a helper in the
+  // exe to get our uploaded reports list.
+  GetUploadedReportsThunk(&uploaded_reports);

[Mark Mentovai, 2015/12/02 03:05:07]

Maybe this ought to be done in crash_reporter::GetUplaodedReports so that the
knowledge of this split doesn’t have to happen in crash_upload_list_crashpad.

[scottmg, 2015/12/02 05:35:00]

I thought it was a bit better here because then at least both pieces of the
split are in chrome/. Otherwise, components/crash/ needs to knows chrome/app,
which seems like it shouldn't. But it's pretty artificial either way, so I'll
switch if you think in crash_reporter is better.

[Mark Mentovai, 2015/12/02 14:59:23]

scottmg wrote:
I guess it is better out here. Who’s to say that non-Chrome clients of the
component will want to split things up in the same way?

+#else
   crash_reporter::GetUploadedReports(&uploaded_reports);
+#endif
 
   ClearUploads();
   for (const crash_reporter::UploadedReport& uploaded_report :
        uploaded_reports) {
     AppendUploadInfo(
         UploadInfo(uploaded_report.remote_id,
                    base::Time::FromTimeT(uploaded_report.creation_time),
                    uploaded_report.local_id, base::Time()));
   }
 }