Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/ui/android/website_settings_popup_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/website_settings_popup_android.h
diff --git a/chrome/browser/ui/android/website_settings_popup_android.h b/chrome/browser/ui/android/website_settings_popup_android.h
index 8df461475a934dd4d86e7b931b20a0e62e499670..efdd32e7f75288009a1d471eb8696c769d23dca8 100644
--- a/chrome/browser/ui/android/website_settings_popup_android.h
+++ b/chrome/browser/ui/android/website_settings_popup_android.h
@@ -34,11 +34,12 @@ class WebsiteSettingsPopupAndroid : public WebsiteSettingsUI {
jobject java_website_settings,
content::WebContents* web_contents);
~WebsiteSettingsPopupAndroid() override;
- void Destroy(JNIEnv* env, jobject obj);
- void OnPermissionSettingChanged(JNIEnv* env,
- jobject obj,
- jint type,
- jint setting);
+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void OnPermissionSettingChanged(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint type,
+ jint setting);
// WebsiteSettingsUI implementations.
void SetCookieInfo(const CookieInfoList& cookie_info_list) override;

Powered by Google App Engine
This is Rietveld 408576698