Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6292)

Unified Diff: chrome/browser/ui/android/website_settings_popup_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/android/website_settings_popup_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/website_settings_popup_android.cc
diff --git a/chrome/browser/ui/android/website_settings_popup_android.cc b/chrome/browser/ui/android/website_settings_popup_android.cc
index e9cab3b4e706e27e06eba7a78c9d3c666b4ad18b..ca785ed0ba8a1bfbbb13f1e51814f6095dcce879 100644
--- a/chrome/browser/ui/android/website_settings_popup_android.cc
+++ b/chrome/browser/ui/android/website_settings_popup_android.cc
@@ -64,14 +64,16 @@ WebsiteSettingsPopupAndroid::WebsiteSettingsPopupAndroid(
WebsiteSettingsPopupAndroid::~WebsiteSettingsPopupAndroid() {}
-void WebsiteSettingsPopupAndroid::Destroy(JNIEnv* env, jobject obj) {
+void WebsiteSettingsPopupAndroid::Destroy(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
delete this;
}
-void WebsiteSettingsPopupAndroid::OnPermissionSettingChanged(JNIEnv* env,
- jobject obj,
- jint type,
- jint setting) {
+void WebsiteSettingsPopupAndroid::OnPermissionSettingChanged(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint type,
+ jint setting) {
ContentSettingsType content_setting_type =
static_cast<ContentSettingsType>(type);
ContentSetting content_setting = static_cast<ContentSetting>(setting);
« no previous file with comments | « chrome/browser/ui/android/website_settings_popup_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698