Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h
diff --git a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h
index 0de051d86ad685434ac1048c4fc7ab2d34133775..96bae6594bbda561385bc647fc9fb5e78e62fcd3 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h
+++ b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h
@@ -27,16 +27,19 @@ class WebContents;
class TabModelJniBridge : public TabModel {
public:
TabModelJniBridge(JNIEnv* env, jobject obj, bool is_incognito);
- void Destroy(JNIEnv* env, jobject obj);
+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
~TabModelJniBridge() override;
// Registers the JNI bindings.
static bool Register(JNIEnv* env);
// Called by JNI
- base::android::ScopedJavaLocalRef<jobject> GetProfileAndroid(JNIEnv* env,
- jobject obj);
- void TabAddedToModel(JNIEnv* env, jobject obj, jobject jtab);
+ base::android::ScopedJavaLocalRef<jobject> GetProfileAndroid(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void TabAddedToModel(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobject>& jtab);
// TabModel::
int GetTabCount() const override;
@@ -57,7 +60,9 @@ class TabModelJniBridge : public TabModel {
// Instructs the TabModel to broadcast a notification that all tabs are now
// loaded from storage.
- void BroadcastSessionRestoreComplete(JNIEnv* env, jobject obj);
+ void BroadcastSessionRestoreComplete(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
protected:
JavaObjectWeakGlobalRef java_object_;

Powered by Google App Engine
This is Rietveld 408576698