chrome/browser/ui/android/javascript_app_modal_dialog_android.h - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/translate_infobar.cc ('k') | chrome/browser/ui/android/javascript_app_modal_dialog_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/javascript_app_modal_dialog_android.h

diff --git a/chrome/browser/ui/android/javascript_app_modal_dialog_android.h b/chrome/browser/ui/android/javascript_app_modal_dialog_android.h

index bef1465583de6e364eb857855cc900d44084bab5..b6a6fc096d31f23fae86bc6657cab99db1330b03 100644

--- a/chrome/browser/ui/android/javascript_app_modal_dialog_android.h

+++ b/chrome/browser/ui/android/javascript_app_modal_dialog_android.h

@@ -30,11 +30,14 @@ class JavascriptAppModalDialogAndroid

bool IsShowing() const override;

// Called when java confirms or cancels the dialog.

- void DidAcceptAppModalDialog(JNIEnv* env,

- jobject obj,

- jstring prompt_text,

+ void DidAcceptAppModalDialog(

+ JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ const base::android::JavaParamRef<jstring>& prompt_text,

+ bool suppress_js_dialogs);

+ void DidCancelAppModalDialog(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>&,

bool suppress_js_dialogs);

- void DidCancelAppModalDialog(JNIEnv* env, jobject, bool suppress_js_dialogs);

const base::android::ScopedJavaGlobalRef<jobject>& GetDialogObject() const;