Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
diff --git a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
index 297a6d06b08801c04adc6ac0dc89fd242882f7bc..cc91515a95e784f89827f5d4da499e71d480b398 100644
--- a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
+++ b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
@@ -108,7 +108,10 @@ void JavascriptAppModalDialogAndroid::AcceptAppModalDialog() {
}
void JavascriptAppModalDialogAndroid::DidAcceptAppModalDialog(
- JNIEnv* env, jobject, jstring prompt, bool should_suppress_js_dialogs) {
+ JNIEnv* env,
+ const JavaParamRef<jobject>&,
+ const JavaParamRef<jstring>& prompt,
+ bool should_suppress_js_dialogs) {
base::string16 prompt_text =
base::android::ConvertJavaStringToUTF16(env, prompt);
dialog_->OnAccept(prompt_text, should_suppress_js_dialogs);
@@ -125,7 +128,9 @@ bool JavascriptAppModalDialogAndroid::IsShowing() const {
}
void JavascriptAppModalDialogAndroid::DidCancelAppModalDialog(
- JNIEnv* env, jobject, bool should_suppress_js_dialogs) {
+ JNIEnv* env,
+ const JavaParamRef<jobject>&,
+ bool should_suppress_js_dialogs) {
dialog_->OnCancel(should_suppress_js_dialogs);
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698