chrome/browser/ui/android/infobars/infobar_android.h - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc ('k') | chrome/browser/ui/android/infobars/infobar_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/infobar_android.h

diff --git a/chrome/browser/ui/android/infobars/infobar_android.h b/chrome/browser/ui/android/infobars/infobar_android.h

index b16f7b530ce4eec21987bead3a8060e3d5262236..bad778f64bdf65f50d8f4bb50c895067db772250 100644

--- a/chrome/browser/ui/android/infobars/infobar_android.h

+++ b/chrome/browser/ui/android/infobars/infobar_android.h

@@ -54,9 +54,13 @@ class InfoBarAndroid : public infobars::InfoBar {

// InfoBar instead of this one.

void ReassignJavaInfoBar(InfoBarAndroid* replacement);

- virtual void OnLinkClicked(JNIEnv* env, jobject obj) {}

- void OnButtonClicked(JNIEnv* env, jobject obj, jint action);

- void OnCloseButtonClicked(JNIEnv* env, jobject obj);

+ virtual void OnLinkClicked(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj) {}

+ void OnButtonClicked(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ jint action);

+ void OnCloseButtonClicked(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

void CloseJavaInfoBar();