chrome/browser/ui/android/infobars/infobar_android.cc - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_android.h ('k') | chrome/browser/ui/android/infobars/infobar_container_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/infobar_android.cc

diff --git a/chrome/browser/ui/android/infobars/infobar_android.cc b/chrome/browser/ui/android/infobars/infobar_android.cc

index 52f59775b52777c745053ef53022ff0a3baae252..5e822fe646523d985a8b36fd9bcd423cbc0a9e01 100644

--- a/chrome/browser/ui/android/infobars/infobar_android.cc

+++ b/chrome/browser/ui/android/infobars/infobar_android.cc

@@ -53,12 +53,13 @@ bool InfoBarAndroid::HasSetJavaInfoBar() const {

}

void InfoBarAndroid::OnButtonClicked(JNIEnv* env,

- jobject obj,

+ const JavaParamRef<jobject>& obj,

jint action) {

ProcessButton(action);

}

-void InfoBarAndroid::OnCloseButtonClicked(JNIEnv* env, jobject obj) {

+void InfoBarAndroid::OnCloseButtonClicked(JNIEnv* env,

+ const JavaParamRef<jobject>& obj) {

if (!owner())

return; // We're closing; don't call anything, it might access the owner.

delegate()->InfoBarDismissed();