Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2801)

Unified Diff: chrome/browser/ui/android/context_menu_helper.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/context_menu_helper.cc
diff --git a/chrome/browser/ui/android/context_menu_helper.cc b/chrome/browser/ui/android/context_menu_helper.cc
index f50c1e82e69c1d88ccffbfe2894a4e426aba4471..87a6f39b81ca4f358fa78d288a1798c5ed25c337 100644
--- a/chrome/browser/ui/android/context_menu_helper.cc
+++ b/chrome/browser/ui/android/context_menu_helper.cc
@@ -103,9 +103,9 @@ ContextMenuHelper::CreateJavaContextMenuParams(
}
void ContextMenuHelper::OnStartDownload(JNIEnv* env,
- jobject obj,
+ const JavaParamRef<jobject>& obj,
jboolean jis_link,
- jstring jheaders) {
+ const JavaParamRef<jstring>& jheaders) {
std::string headers(ConvertJavaStringToUTF8(env, jheaders));
content::DownloadControllerAndroid::Get()->StartContextMenuDownload(
context_menu_params_,
@@ -114,12 +114,14 @@ void ContextMenuHelper::OnStartDownload(JNIEnv* env,
headers);
}
-void ContextMenuHelper::SearchForImage(JNIEnv* env, jobject obj) {
+void ContextMenuHelper::SearchForImage(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
CoreTabHelper::FromWebContents(web_contents_)->SearchByImageInNewTab(
context_menu_params_.src_url);
}
-void ContextMenuHelper::ShareImage(JNIEnv* env, jobject obj) {
+void ContextMenuHelper::ShareImage(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
CoreTabHelper::FromWebContents(web_contents_)->
RequestThumbnailForContextNode(
0,
« no previous file with comments | « chrome/browser/ui/android/context_menu_helper.h ('k') | chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698