chrome/browser/ui/android/connection_info_popup_android.h - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/connection_info_popup_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/chrome_http_auth_handler.cc ('k') | chrome/browser/ui/android/connection_info_popup_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/connection_info_popup_android.h

diff --git a/chrome/browser/ui/android/connection_info_popup_android.h b/chrome/browser/ui/android/connection_info_popup_android.h

index aac48d54aca72156e1e66b4ae64b88ecd6a4297c..fe9288a2dedccf8834ec8780859a87cc9738a491 100644

--- a/chrome/browser/ui/android/connection_info_popup_android.h

+++ b/chrome/browser/ui/android/connection_info_popup_android.h

@@ -24,11 +24,14 @@ class ConnectionInfoPopupAndroid : public WebsiteSettingsUI {

jobject java_website_settings,

content::WebContents* web_contents);

~ConnectionInfoPopupAndroid() override;

- void Destroy(JNIEnv* env, jobject obj);

+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

// Revokes any current user exceptions for bypassing SSL error interstitials

// on this page.

- void ResetCertDecisions(JNIEnv* env, jobject obj, jobject java_web_contents);

+ void ResetCertDecisions(

+ JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ const base::android::JavaParamRef<jobject>& java_web_contents);

// WebsiteSettingsUI implementations.

void SetCookieInfo(const CookieInfoList& cookie_info_list) override;