Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/ui/android/chrome_http_auth_handler.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/chrome_http_auth_handler.cc
diff --git a/chrome/browser/ui/android/chrome_http_auth_handler.cc b/chrome/browser/ui/android/chrome_http_auth_handler.cc
index 881e205cccc5550d62843700b6483b8753460daf..104de75ac8d397841161651bd59d2db1d635b421 100644
--- a/chrome/browser/ui/android/chrome_http_auth_handler.cc
+++ b/chrome/browser/ui/android/chrome_http_auth_handler.cc
@@ -62,9 +62,9 @@ void ChromeHttpAuthHandler::OnAutofillDataAvailable(
}
void ChromeHttpAuthHandler::SetAuth(JNIEnv* env,
- jobject,
- jstring username,
- jstring password) {
+ const JavaParamRef<jobject>&,
+ const JavaParamRef<jstring>& username,
+ const JavaParamRef<jstring>& password) {
if (observer_) {
base::string16 username16 = ConvertJavaStringToUTF16(env, username);
base::string16 password16 = ConvertJavaStringToUTF16(env, password);
@@ -72,13 +72,15 @@ void ChromeHttpAuthHandler::SetAuth(JNIEnv* env,
}
}
-void ChromeHttpAuthHandler::CancelAuth(JNIEnv* env, jobject) {
+void ChromeHttpAuthHandler::CancelAuth(JNIEnv* env,
+ const JavaParamRef<jobject>&) {
if (observer_)
observer_->CancelAuth();
}
ScopedJavaLocalRef<jstring> ChromeHttpAuthHandler::GetMessageBody(
- JNIEnv* env, jobject) {
+ JNIEnv* env,
+ const JavaParamRef<jobject>&) {
return ConvertUTF16ToJavaString(env, explanation_);
}
« no previous file with comments | « chrome/browser/ui/android/chrome_http_auth_handler.h ('k') | chrome/browser/ui/android/connection_info_popup_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698