Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3989)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index f26ee0f18ceb758570d7486f5ed7f9bbfccf7b7f..7fd3231176f6b34f93d4b6ec91dbcd59420a9c08 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -95,17 +95,19 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
env, java_object_.obj(), data_array.obj(), controller_->IsRTL());
}
-void AutofillPopupViewAndroid::SuggestionSelected(JNIEnv* env,
- jobject obj,
- jint list_index) {
+void AutofillPopupViewAndroid::SuggestionSelected(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint list_index) {
// Race: Hide() may have already run.
if (controller_)
controller_->AcceptSuggestion(list_index);
}
-void AutofillPopupViewAndroid::DeletionRequested(JNIEnv* env,
- jobject obj,
- jint list_index) {
+void AutofillPopupViewAndroid::DeletionRequested(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint list_index) {
if (!controller_)
return;
@@ -125,8 +127,9 @@ void AutofillPopupViewAndroid::DeletionRequested(JNIEnv* env,
env, confirmation_body).obj());
}
-void AutofillPopupViewAndroid::DeletionConfirmed(JNIEnv* env,
- jobject obj) {
+void AutofillPopupViewAndroid::DeletionConfirmed(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
if (!controller_)
return;
@@ -134,7 +137,9 @@ void AutofillPopupViewAndroid::DeletionConfirmed(JNIEnv* env,
controller_->RemoveSuggestion(deleting_index_);
}
-void AutofillPopupViewAndroid::PopupDismissed(JNIEnv* env, jobject obj) {
+void AutofillPopupViewAndroid::PopupDismissed(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
if (controller_)
controller_->ViewDestroyed();

Powered by Google App Engine
This is Rietveld 408576698