Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 148153016: Fix platform checks in Clipboard. (Closed)

Created:
6 years, 10 months ago by kalyank
Modified:
6 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix platform checks in Clipboard. Ozone uses clipboard_aura and DChecks in WriteObjects with type CLIPBOARD_TYPE_SELECTION fail here as this is defined only for X11 platform. This CL replaces the current platform checks(X11) with checks this shouldn't be defined on. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247635

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/clipboard/clipboard.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kalyank
6 years, 10 months ago (2014-01-28 23:32:28 UTC) #1
kalyank
On 2014/01/28 23:32:28, kalyank wrote: This is causing DCHECK failure when using Chromium with Aura ...
6 years, 10 months ago (2014-01-28 23:42:19 UTC) #2
dcheng
https://codereview.chromium.org/148153016/diff/1/ui/base/clipboard/clipboard.h File ui/base/clipboard/clipboard.h (right): https://codereview.chromium.org/148153016/diff/1/ui/base/clipboard/clipboard.h#newcode187 ui/base/clipboard/clipboard.h:187: #if defined(USE_AURA) && (!defined(OS_WIN) && !defined(OS_CHROMEOS)) Hm... Perhaps it'd ...
6 years, 10 months ago (2014-01-28 23:44:18 UTC) #3
kalyank
https://codereview.chromium.org/148153016/diff/1/ui/base/clipboard/clipboard.h File ui/base/clipboard/clipboard.h (right): https://codereview.chromium.org/148153016/diff/1/ui/base/clipboard/clipboard.h#newcode187 ui/base/clipboard/clipboard.h:187: #if defined(USE_AURA) && (!defined(OS_WIN) && !defined(OS_CHROMEOS)) On 2014/01/28 23:44:18, ...
6 years, 10 months ago (2014-01-29 02:10:47 UTC) #4
dcheng
LGTM
6 years, 10 months ago (2014-01-29 02:16:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/148153016/20001
6 years, 10 months ago (2014-01-29 02:38:04 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:57:47 UTC) #7
Message was sent while issue was closed.
Change committed as 247635

Powered by Google App Engine
This is Rietveld 408576698