Issue 148153013: Fix mistaken assumptions in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148153013: Fix mistaken assumptions in tests (Closed)

Created:
6 years, 10 months ago by abarth-chromium

Modified:
6 years, 10 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix mistaken assumptions in tests This test assumes that spinning the event loop is sufficient to trigger asynchronous style recalculation. After we move style recalculation to be triggered off requestAnimationFrame, this assumption will no longer be valid. This CL removes this assumption by triggering layout explicitly R=fsamuel@chromium.org BUG=337617 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247563

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	content/renderer/browser_plugin/browser_plugin_browsertest.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/148153013/1

6 years, 10 months ago (2014-01-28 20:09:24 UTC) #3

Message was sent while issue was closed.

Change committed as 247563

Expand Messages | Collapse Messages