Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: LayoutTests/fast/harness/results.html

Issue 148153009: DOM-object leak detection at run_webkit_tests.py (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Bug fix: unit test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/harness/results.html
diff --git a/LayoutTests/fast/harness/results.html b/LayoutTests/fast/harness/results.html
index 1aeaae3a460c646cabc289560a74b8112e39f63b..c2578da0c2c0ec5cdcbd975dd9f427791aa18c3e 100644
--- a/LayoutTests/fast/harness/results.html
+++ b/LayoutTests/fast/harness/results.html
@@ -206,6 +206,7 @@ function globalState()
if (!g_state) {
g_state = {
crashTests: [],
+ leakTests: [],
flakyPassTests: [],
hasHttpTests: false,
hasImageFailures: false,
@@ -491,6 +492,11 @@ function processGlobalStateFor(testObject)
return;
}
+ if (actual == 'LEAK') {
+ globalState().leakTests.push(testObject);
+ return;
+ }
+
if (actual == 'TIMEOUT') {
globalState().timeoutTests.push(testObject);
return;
@@ -681,7 +687,9 @@ function testList(tests, header, tableId)
else if (tableId == 'crash-tests-table') {
html += resultLink(stripExtension(test), '-crash-log.txt', 'crash log');
html += resultLink(stripExtension(test), '-sample.txt', 'sample');
- } else if (tableId == 'timeout-tests-table') {
+ } else if (tableId == 'leak-tests-table')
+ html += resultLink(stripExtension(test), '-leak-log.txt', 'leak log');
+ else if (tableId == 'timeout-tests-table') {
// FIXME: only include timeout actual/diff results here if we actually spit out results for timeout tests.
html += textResultLinks(stripExtension(test));
}
@@ -1330,6 +1338,9 @@ function generatePage()
if (globalState().crashTests.length)
html += testList(globalState().crashTests, 'Tests that crashed', 'crash-tests-table');
+ if (globalState().leakTests.length)
+ html += testList(globalState().leakTests, 'Tests that leaked', 'leak-tests-table');
+
html += failingTestsTable(globalState().failingTests,
'Tests that failed text/pixel/audio diff', 'results-table');
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698