chrome/browser/extensions/extension_function_dispatcher.cc - Issue 148153008: Protocol handler dialogs should only be enabled by browser or page actions [Not committed]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_dispatcher.cc

Issue 148153008: Protocol handler dialogs should only be enabled by browser or page actions [Not committed] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_function_dispatcher.cc

diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc

index 17da794b1e3131e12e2ee4756ebdd75bbd48a6c6..1b49696df0e569dc100d7fab5e467f15ae255485 100644

--- a/chrome/browser/extensions/extension_function_dispatcher.cc

+++ b/chrome/browser/extensions/extension_function_dispatcher.cc

@@ -20,7 +20,6 @@

#include "chrome/browser/extensions/extension_system.h"

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/extension_web_ui.h"

-#include "chrome/browser/external_protocol/external_protocol_handler.h"

#include "chrome/browser/renderer_host/chrome_render_message_filter.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/url_constants.h"

@@ -383,9 +382,6 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(

base::TimeTicks::Now());

if (violation_error.empty()) {

scoped_ptr<base::ListValue> args(params.arguments.DeepCopy());

- // See crbug.com/39178.

- ExternalProtocolHandler::PermitLaunchUrl();

LogSuccess(extension->id(), params.name, args.Pass(), browser_context_);

function->Run();

} else {