runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart - Issue 148153007: Add Google Charts to Observatory and use it in allocation profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart

Issue 148153007: Add Google Charts to Observatory and use it in allocation profiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory/chart.dart ('K') | « runtime/bin/vmservice/client/lib/src/observatory/chart.dart ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart b/runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart

index a0cbc7f4ff2322804108ad990445ba8bb15e0eea..376aa1a86c170f04b451b5193a80a07ef57da3fd 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart

@@ -56,7 +56,7 @@ abstract class RequestManager extends Observable {

setResponses([{

'type': 'Error',

'errorType': 'RequestError',

- 'error': error

+ 'text': error

Cutch 2014/01/27 19:53:11 <error-view tag requires a 'text' entry.

}]);

}

@@ -205,7 +205,7 @@ abstract class RequestManager extends Observable {

}

void _requestCatchError(e, st) {

- if (e is HttpRequest) {

Cutch 2014/01/27 19:53:11 Fix warning in editor.

+ if (e is ProgressEvent) {

setResponseRequestError(e.target);

} else {

setResponseError('$e $st');