third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp - Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/modules.gypi ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

index a156a9497f0c203064c25a485e073dc41a26c4a1..8070617fe66e95da9f14dbbdb08faf8b45ba1c45 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

@@ -14,6 +14,7 @@

#include "modules/serviceworkers/ServiceWorkerError.h"

#include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"

#include "modules/serviceworkers/ServiceWorkerWindowClient.h"

+#include "modules/serviceworkers/ServiceWorkerWindowClientCallback.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerClientQueryOptions.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"

#include "wtf/OwnPtr.h"

@@ -127,7 +128,7 @@ ScriptPromise ServiceWorkerClients::openWindow(ScriptState* scriptState, const S

}

context->consumeWindowInteraction();

- ServiceWorkerGlobalScopeClient::from(context)->openWindow(parsedUrl, new CallbackPromiseAdapter<ServiceWorkerWindowClient, ServiceWorkerError>(resolver));

+ ServiceWorkerGlobalScopeClient::from(context)->openWindow(parsedUrl, new NavigateClientCallback(resolver));

return promise;

}