Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 7a5e37e75930e44bd93e8d30ccd006722b4d4491..62bfb8517986377788c181b1db546298a95f9957 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -866,7 +866,7 @@ void ServiceWorkerContextClient::OnOpenWindowError(
return;
}
callbacks->onError(blink::WebServiceWorkerError(
- blink::WebServiceWorkerError::ErrorTypeUnknown,
+ blink::WebServiceWorkerError::ErrorTypeNavigation,
blink::WebString::fromUTF8(message)));
context_->client_callbacks.Remove(request_id);
}
@@ -929,7 +929,7 @@ void ServiceWorkerContextClient::OnNavigateClientError(int request_id,
}
std::string message = "Cannot navigate to URL: " + url.spec();
callbacks->onError(blink::WebServiceWorkerError(
- blink::WebServiceWorkerError::ErrorTypeUnknown,
+ blink::WebServiceWorkerError::ErrorTypeNavigation,
blink::WebString::fromUTF8(message)));
context_->client_callbacks.Remove(request_id);
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698