content/renderer/service_worker/service_worker_context_client.cc - Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index 7a5e37e75930e44bd93e8d30ccd006722b4d4491..62bfb8517986377788c181b1db546298a95f9957 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -866,7 +866,7 @@ void ServiceWorkerContextClient::OnOpenWindowError(

return;

}

callbacks->onError(blink::WebServiceWorkerError(

- blink::WebServiceWorkerError::ErrorTypeUnknown,

+ blink::WebServiceWorkerError::ErrorTypeNavigation,

blink::WebString::fromUTF8(message)));

context_->client_callbacks.Remove(request_id);

}

@@ -929,7 +929,7 @@ void ServiceWorkerContextClient::OnNavigateClientError(int request_id,

}

std::string message = "Cannot navigate to URL: " + url.spec();

callbacks->onError(blink::WebServiceWorkerError(

- blink::WebServiceWorkerError::ErrorTypeUnknown,

+ blink::WebServiceWorkerError::ErrorTypeNavigation,

blink::WebString::fromUTF8(message)));

context_->client_callbacks.Remove(request_id);

}