third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html - Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html

Issue 1481523006: ServiceWorker: Should throw TypeError instead of Unknown/SecurityError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html

index ba7e3fb32ba2f41caaa9457dcff1d863574b8bfd..2d3e8e189dcf8f90b1004fe70792595d39711ea5 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html

@@ -26,15 +26,11 @@ var test_list = [

var expected = [

location.origin + '/serviceworker/resources/blank.html',

- // TODO(zino): Should TypeError instead of UnknownError.

- // Please see: http://crbug.com/540503

- 'UnknownError',

+ 'TypeError',

null,

'TypeError',

- // TODO(zino): Should TypeError instead of UnknownError.

- // Please see: http://crbug.com/540503

- 'UnknownError',

- 'SecurityError',

+ 'TypeError',

'TypeError',

'TypeError'

];