tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp - Issue 1481523005: GC plugin: have -Werror issue errors for inputs having only warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

Issue 1481523005: GC plugin: have -Werror issue errors for inputs having only warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add -Werror test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

index 441138a724b25ef6ba0070d8a4d84efc58aaa288..5c1605bd6368271a7c7c5be53c138cdc409afaef 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

@@ -218,7 +218,7 @@ BlinkGCPluginConsumer::BlinkGCPluginConsumer(

diag_class_contains_invalid_fields_ = diagnostic_.getCustomDiagID(

getErrorLevel(), kClassContainsInvalidFields);

diag_class_contains_invalid_fields_warning_ = diagnostic_.getCustomDiagID(

- DiagnosticsEngine::Warning, kClassContainsInvalidFields);

+ getErrorLevel(), kClassContainsInvalidFields);

diag_class_contains_gc_root_ =

diagnostic_.getCustomDiagID(getErrorLevel(), kClassContainsGCRoot);

diag_class_requires_finalization_ = diagnostic_.getCustomDiagID(

« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class_error.h » ('j') | no next file with comments »