master: more underlying types

master: more underlying types

Precursor to https://codereview.chromium.org/1477583002/

Also:
merge where possible.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3caa6537663e85ad6874c4420907d2ab885c80ea

[Tom Sepez, 2015-11-25 20:07:50]

Description was changed from

==========
master: more underlying types

Also:
merge where possible.
==========

to

==========
master: more underlying types

Precursor to https://codereview.chromium.org/1477583002/

Also:
merge where possible.
==========

[Tom Sepez, 2015-11-25 20:07:50]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-11-25 20:08:57]

Lei, ready for review.

[Lei Zhang, 2015-11-25 22:34:42]

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdfsave.cpp
File fpdfsdk/src/fpdfsave.cpp (right):

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdfsave.cpp#ne...
fpdfsdk/src/fpdfsave.cpp:60: CPDF_Document* pPDFDoc =
CPDFDocumentFromFPDFDocument(document);
UnderlyingDocumentType?

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdftext.cpp
File fpdfsdk/src/fpdftext.cpp (right):

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdftext.cpp#ne...
fpdfsdk/src/fpdftext.cpp:18: CPDF_Page* pPDFPage = CPDFPageFromFPDFPage(page);
UnderlyingPageType?

[Tom Sepez, 2015-11-25 22:50:25]

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdfsave.cpp
File fpdfsdk/src/fpdfsave.cpp (right):

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdfsave.cpp#ne...
fpdfsdk/src/fpdfsave.cpp:60: CPDF_Document* pPDFDoc =
CPDFDocumentFromFPDFDocument(document);
On 2015/11/25 22:34:42, Lei Zhang wrote:
> UnderlyingDocumentType?
No, because CPDF_Creator::CPDF_Creator() takes a CPDF_Document* arg.  This just
makes the names line up (XFA has a second document ptr called pDoc which
conflicts otherwise).

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdftext.cpp
File fpdfsdk/src/fpdftext.cpp (right):

https://codereview.chromium.org/1481523004/diff/1/fpdfsdk/src/fpdftext.cpp#ne...
fpdfsdk/src/fpdftext.cpp:18: CPDF_Page* pPDFPage = CPDFPageFromFPDFPage(page);
On 2015/11/25 22:34:42, Lei Zhang wrote:
> UnderlyingPageType?

No, because IPDF_TextPage::CreateTextPage wants a CPDF_Document* arg even in the
xfa branch.

[Lei Zhang, 2015-11-25 22:51:10]

lgtm

[Tom Sepez, 2015-11-25 22:54:14]

Description was changed from

==========
master: more underlying types

Precursor to https://codereview.chromium.org/1477583002/

Also:
merge where possible.
==========

to

==========
master: more underlying types

Precursor to https://codereview.chromium.org/1477583002/

Also:
merge where possible.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/3caa6537663e85ad6874c4420907d2ab885c...
==========

[Tom Sepez, 2015-11-25 22:54:15]

Committed patchset #1 (id:1) manually as
3caa6537663e85ad6874c4420907d2ab885c80ea (presubmit successful).