Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1481513002: Revert of Removed support deprecated (//@|/*@) source(URL|MappingURL)= (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
kozy, Michael Achenbach
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Removed support deprecated (//@|/*@) source(URL|MappingURL)= (patchset #1 id:1 of https://codereview.chromium.org/1474543005/ ) Reason for revert: Failing layout tests: inspector/tracing/timeline-event-causes.html virtual/syncpaint/inspector/tracing/timeline-event-causes.html inspector/animation/animation-timeline-fill.html virtual/threaded/inspector/tracing/timeline-event-causes.html inspector/tracing/timeline-script-id.html inspector/sources/debugger-ui/source-url-comment.html inspector/console/console-log-linkify-stack-in-errors.html virtual/syncpaint/inspector/tracing/timeline-script-id.html virtual/threaded/inspector/tracing/timeline-script-id.html Original issue's description: > Removed support deprecated (//@|/*@) source(URL|MappingURL)= > > LOG=Y > BUG=chromium:558998 > R=yangguo@chromium.org > > Committed: https://crrev.com/c1e5f005d79c436d90f474f8bc6448c4555a619f > Cr-Commit-Position: refs/heads/master@{#32249} TBR=machenbach@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:558998 Committed: https://crrev.com/1db01d6d5d33842536b19fb8a2767dd5f6bdaa3c Cr-Commit-Position: refs/heads/master@{#32259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M include/v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/js/messages.js View 1 chunk +4 lines, -3 lines 0 comments Download
M src/scanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-conditional-position.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-109362.js View 2 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-481896.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-517592.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of Removed support deprecated (//@|/*@) source(URL|MappingURL)=
5 years ago (2015-11-25 10:26:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481513002/1
5 years ago (2015-11-25 10:27:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 10:27:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1db01d6d5d33842536b19fb8a2767dd5f6bdaa3c Cr-Commit-Position: refs/heads/master@{#32259}
5 years ago (2015-11-25 10:28:08 UTC) #4
Michael Achenbach
5 years ago (2015-11-25 12:21:14 UTC) #5
Message was sent while issue was closed.
Looks like this was the cause. Cycled green now:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Please request rebase upstream first and add one of the chromium trybots on
reland (they'll execute the layout tests).

Powered by Google App Engine
This is Rietveld 408576698