Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1481493003: Fix JSFunction's in-object properties initialization. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSFunction's in-object properties initialization. BUG=v8:4572 LOG=Y Committed: https://crrev.com/ebf8ec5c510c4fe5dde7e8e75a25027da62b16ba Cr-Commit-Position: refs/heads/master@{#32268}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M src/factory.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/factory.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M src/heap/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481493003/20001
5 years ago (2015-11-25 11:04:26 UTC) #3
Igor Sheludko
PTAL
5 years ago (2015-11-25 11:04:35 UTC) #5
ulan
Heap part lgtm. https://codereview.chromium.org/1481493003/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1481493003/diff/20001/src/heap/heap.cc#newcode3440 src/heap/heap.cc:3440: if (start_offset >= map->instance_size()) return; As ...
5 years ago (2015-11-25 11:11:51 UTC) #7
Igor Sheludko
https://codereview.chromium.org/1481493003/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1481493003/diff/20001/src/heap/heap.cc#newcode3440 src/heap/heap.cc:3440: if (start_offset >= map->instance_size()) return; On 2015/11/25 11:11:51, ulan ...
5 years ago (2015-11-25 11:25:40 UTC) #8
Toon Verwaest
lgtm
5 years ago (2015-11-25 11:32:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481493003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481493003/40001
5 years ago (2015-11-25 11:46:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481493003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481493003/40001
5 years ago (2015-11-25 12:17:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-11-25 12:41:39 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-25 12:42:27 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ebf8ec5c510c4fe5dde7e8e75a25027da62b16ba
Cr-Commit-Position: refs/heads/master@{#32268}

Powered by Google App Engine
This is Rietveld 408576698