(mips) adding simulator support for AUI/DAUI/DAHI/DATI instructions.

MIPS: Adding simulator support for AUI/DAUI/DAHI/DATI.

BUG=

Committed: https://crrev.com/cfd9beeced00f8974d3859a48b072d73d78b9318
Cr-Commit-Position: refs/heads/master@{#32417}

[Alan Li, 2015-11-25 04:25:13]

Description was changed from

==========
(mips) adding simulator support for AUI/DAUI/DAHI/DATI instructions.

BUG=
==========

to

==========
(mips) adding simulator support for AUI/DAUI/DAHI/DATI instructions.

BUG=
==========

[Alan Li, 2015-11-25 04:25:13]

alan.li@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, djordje.pesic@imgtec.com,
ivica.bogosavljevic@imgtec.com, paul.lind@imgtec.com

[Djordje.Pesic, 2015-11-25 08:28:31]

On 2015/11/25 04:25:13, Alan Li wrote:
> mailto:alan.li@imgtec.com changed reviewers:
> + mailto:akos.palfi@imgtec.com, mailto:balazs.kilvady@imgtec.com,
mailto:djordje.pesic@imgtec.com,
> mailto:ivica.bogosavljevic@imgtec.com, mailto:paul.lind@imgtec.com

You probably should add disasesmbler tests for AUI/DAUI/DAHI/DATI instructions
(mips and mips64).

[Alan Li, 2015-11-26 02:36:51]

On 2015/11/25 08:28:31, Djordje.Pesic wrote:
> On 2015/11/25 04:25:13, Alan Li wrote:
> > mailto:alan.li@imgtec.com changed reviewers:
> > + mailto:akos.palfi@imgtec.com, mailto:balazs.kilvady@imgtec.com,
> mailto:djordje.pesic@imgtec.com,
> > mailto:ivica.bogosavljevic@imgtec.com, mailto:paul.lind@imgtec.com
> 
> You probably should add disasesmbler tests for AUI/DAUI/DAHI/DATI instructions
> (mips and mips64).

Done

[Djordje.Pesic, 2015-11-26 06:54:55]

On 2015/11/26 02:36:51, Alan Li wrote:
> On 2015/11/25 08:28:31, Djordje.Pesic wrote:
> > On 2015/11/25 04:25:13, Alan Li wrote:
> > > mailto:alan.li@imgtec.com changed reviewers:
> > > + mailto:akos.palfi@imgtec.com, mailto:balazs.kilvady@imgtec.com,
> > mailto:djordje.pesic@imgtec.com,
> > > mailto:ivica.bogosavljevic@imgtec.com, mailto:paul.lind@imgtec.com
> > 
> > You probably should add disasesmbler tests for AUI/DAUI/DAHI/DATI
instructions
> > (mips and mips64).
> 
> Done

lgtm. Needs approval from mips owner.

[balazs.kilvady, 2015-11-26 17:10:51]

lgtm with nits. The DCHECK(!rs.is(zero_reg)); from aui() can be removed in a
followup CL if we decide to do that.

https://codereview.chromium.org/1481493002/diff/20001/src/mips/simulator-mips.cc
File src/mips/simulator-mips.cc (right):

https://codereview.chromium.org/1481493002/diff/20001/src/mips/simulator-mips...
src/mips/simulator-mips.cc:4042: case LUI:
Please use this kind of comment (like at branches):
    case LUI:  // AUI, LUI (pre-r6)
In the next if else blocks on r6 both blocks are AUI's so those comments are
slightly miss-leading.

https://codereview.chromium.org/1481493002/diff/20001/src/mips64/assembler-mi...
File src/mips64/assembler-mips64.cc (right):

https://codereview.chromium.org/1481493002/diff/20001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1960: DCHECK(!(rs.is(zero_reg)));
The documantaison says 'In Release 6, LUI is an assembly idiom for AUI with
rs=0.' It does not mean rs cannot be zero_reg and lui must be used. Also the
above comment is not true completly. Do we need this restriction?
The same note/question for mips32.

https://codereview.chromium.org/1481493002/diff/20001/src/mips64/simulator-mi...
File src/mips64/simulator-mips64.cc (right):

https://codereview.chromium.org/1481493002/diff/20001/src/mips64/simulator-mi...
src/mips64/simulator-mips64.cc:4116: case LUI:
Please use this kind of comment (like at branches):
    case LUI:  // AUI, LUI (pre-r6)
In the next if else blocks on r6 both blocks are AUI's so those comments are
slightly miss-leading.

[balazs.kilvady, 2015-11-26 17:10:53]

lgtm with nits. The DCHECK(!rs.is(zero_reg)); from aui() can be removed in a
followup CL if we decide to do that.

[balazs.kilvady, 2015-11-27 15:54:35]

Also please edit the message - 'MIPS:' instead of '(mips)' . And start the
sentence with a capital 'A' :)

[Alan Li, 2015-11-30 14:38:30]

On 2015/11/27 15:54:35, balazs.kilvady wrote:
> Also please edit the message - 'MIPS:' instead of '(mips)' . And start the
> sentence with a capital 'A' :)

just uploaded a new version, however it went to another CL for some reason
(possibly because I changed the commit comment):
https://codereview.chromium.org/1483033002

Is there a way we could link them together, or avoid creating a new CL?

[Alan Li, 2015-11-30 17:13:39]

Description was changed from

==========
(mips) adding simulator support for AUI/DAUI/DAHI/DATI instructions.

BUG=
==========

to

==========
MIPS: Adding simulator support for AUI/DAUI/DAHI/DATI.

BUG=
==========

[Jakob Kummerow, 2015-11-30 17:15:14]

On 2015/11/30 14:38:30, Alan Li wrote:
> On 2015/11/27 15:54:35, balazs.kilvady wrote:
> > Also please edit the message - 'MIPS:' instead of '(mips)' . And start the
> > sentence with a capital 'A' :)
> 
> just uploaded a new version, however it went to another CL for some reason
> (possibly because I changed the commit comment):
> https://codereview.chromium.org/1483033002
> 
> Is there a way we could link them together, or avoid creating a new CL?

You can't link existing codereview issues. (However you can delete the
erroneously created one.)

Codereview issues are associated with git branches. If you create a new branch
and do "git cl upload" on it, it'll create a new issue. You can manually manage
associated issues using "git cl issue": "git cl issue 0" resets the association,
"git cl issue 1481493002" sets it to this issue here.

To change the description/message, you don't need to do anything locally on your
machine. Just click "Edit issue" in the top left corner. (Pro tip: don't change
the "subject", so notification emails will still get grouped together, only edit
the "description" which is what will be used for the commit.)

[Alan Li, 2015-11-30 17:25:51]

The CQ bit was checked by alan.li@imgtec.com

[commit-bot: I haz the power, 2015-11-30 17:26:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481493002/20001

[commit-bot: I haz the power, 2015-11-30 17:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 17:30:04]

Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Alan Li, 2015-11-30 18:07:10]

The CQ bit was checked by alan.li@imgtec.com

[Alan Li, 2015-11-30 18:07:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
balazs.kilvady@imgtec.com, Djordje.Pesic@imgtec.com
Link to the patchset: https://codereview.chromium.org/1481493002/#ps40001
(title: "fix broken compilation errors.")

[commit-bot: I haz the power, 2015-11-30 18:07:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481493002/40001

[commit-bot: I haz the power, 2015-11-30 18:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 18:10:27]

Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Alan Li, 2015-11-30 19:04:02]

The CQ bit was checked by alan.li@imgtec.com

[Alan Li, 2015-11-30 19:04:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
balazs.kilvady@imgtec.com, Djordje.Pesic@imgtec.com
Link to the patchset: https://codereview.chromium.org/1481493002/#ps60001
(title: "fix mips64 compilation error.")

[commit-bot: I haz the power, 2015-11-30 19:04:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481493002/60001

[commit-bot: I haz the power, 2015-11-30 20:30:10]

Description was changed from

==========
MIPS: Adding simulator support for AUI/DAUI/DAHI/DATI.

BUG=
==========

to

==========
MIPS: Adding simulator support for AUI/DAUI/DAHI/DATI.

BUG=
==========

[commit-bot: I haz the power, 2015-11-30 20:30:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-30 20:30:30]

Description was changed from

==========
MIPS: Adding simulator support for AUI/DAUI/DAHI/DATI.

BUG=
==========

to

==========
MIPS: Adding simulator support for AUI/DAUI/DAHI/DATI.

BUG=

Committed: https://crrev.com/cfd9beeced00f8974d3859a48b072d73d78b9318
Cr-Commit-Position: refs/heads/master@{#32417}
==========

[commit-bot: I haz the power, 2015-11-30 20:30:30]

Patchset 4 (id:??) landed as
https://crrev.com/cfd9beeced00f8974d3859a48b072d73d78b9318
Cr-Commit-Position: refs/heads/master@{#32417}