Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1481443002: [DevTools] Fix browser crash when instantiating AbdTargetUIHandler for incognito profile. (Closed)

Created:
5 years ago by dgozman
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix browser crash when instantiating AbdTargetUIHandler for incognito profile. DevTools window from incognito profile will use original one's DevToolsAndroidBridge. BUG=560643 Committed: https://crrev.com/50ef6858b9612520c0d50b543ed5762930152efa Cr-Commit-Position: refs/heads/master@{#361531}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years ago (2015-11-25 00:23:12 UTC) #2
pfeldman
lgtm
5 years ago (2015-11-25 00:28:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481443002/20001
5 years ago (2015-11-25 00:43:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 03:11:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 03:12:03 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/50ef6858b9612520c0d50b543ed5762930152efa
Cr-Commit-Position: refs/heads/master@{#361531}

Powered by Google App Engine
This is Rietveld 408576698