Issue 1481433002: Remove template in settings.html, move <settings-prefs> into <settings-ui>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1481433002: Remove template in settings.html, move <settings-prefs> into <settings-ui> (Closed)

Created:
5 years ago by michaelpg

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@PerformanceExploration2

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove template in settings.html, move <settings-prefs> into <settings-ui> This patch compared to ToT: Increases page load in test from 4634ms to 6123ms (32% slower) This patch compared to previous patch: Increases page load in test from 3808ms to 6123ms (61% slower) NOCOMMIT=TRUE

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	chrome/browser/resources/settings/settings.html	View		1 chunk	+1 line, -5 lines	0 comments	Download
	M	chrome/browser/resources/settings/settings_ui/settings_ui.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1470263003 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

michaelpg

4 years, 10 months ago (2016-02-11 05:04:19 UTC) #1

Description was changed from

==========
Remove template in settings.html, move <settings-prefs> into <settings-ui>

This patch compared to ToT:
Increases page load in test from 4634ms to 6123ms (32% slower)

This patch compared to previous patch:
Increases page load in test from 3808ms to 6123ms (61% slower)



NOCOMMIT=TRUE
==========

to

==========
Remove template in settings.html, move <settings-prefs> into <settings-ui>

This patch compared to ToT:
Increases page load in test from 4634ms to 6123ms (32% slower)

This patch compared to previous patch:
Increases page load in test from 3808ms to 6123ms (61% slower)



NOCOMMIT=TRUE
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages