Add notification mechanism when BrowserActionButton's icon has been updated.

ui/views/controls/menu/menu_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_item_view.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_resources.h"
@@ skipping 70 matching lines @@
 
 // static
 int MenuItemView::item_right_margin_;
 
 // static
 int MenuItemView::pref_menu_height_;
 
 // static
 const char MenuItemView::kViewClassName[] = "MenuItemView";
 
+// Note: This class also has a protected constructor and a common Init function
+// to initialize both.
 MenuItemView::MenuItemView(MenuDelegate* delegate)
     : delegate_(delegate),
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(NULL),
       type_(SUBMENU),
       selected_(false),
       command_(0),
       submenu_(NULL),
       has_mnemonics_(false),
@@ skipping 451 matching lines @@
   invalidate_dimensions();
 }
 
 const MenuConfig& MenuItemView::GetMenuConfig() const {
   const MenuController* controller = GetMenuController();
   if (controller)
     return controller->menu_config_;
   return MenuConfig::instance(NULL);
 }
 
+// Note: This class also has a public constructor and a common Init function
+// to initialize both.
 MenuItemView::MenuItemView(MenuItemView* parent,
                            int command,
                            MenuItemView::Type type)
     : delegate_(NULL),
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(parent),
       type_(type),
       selected_(false),
       command_(command),
       submenu_(NULL),
       has_mnemonics_(false),
       show_mnemonics_(false),
       has_icons_(false),
       icon_view_(NULL),
       top_margin_(-1),
       bottom_margin_(-1),
       left_icon_margin_(0),
       right_icon_margin_(0),
       requested_menu_position_(POSITION_BEST_FIT),
       actual_menu_position_(requested_menu_position_),
       use_right_margin_(true) {
   Init(parent, command, type, NULL);
 }
 
 MenuItemView::~MenuItemView() {
   delete submenu_;
   STLDeleteElements(&removed_items_);
+  if (lifecycle_observer_)
+    lifecycle_observer_->OnDeleted(this);
 }
 
 const char* MenuItemView::GetClassName() const {
   return kViewClassName;
 }
 
 // Calculates all sizes that we can from the OS.
 //
 // This is invoked prior to Running a menu.
 void MenuItemView::UpdateMenuPartSizes() {
@@ skipping 34 matching lines @@
   canceled_ = false;
   parent_menu_item_ = parent;
   type_ = type;
   selected_ = false;
   command_ = command;
   submenu_ = NULL;
   show_mnemonics_ = false;
   // Assign our ID, this allows SubmenuItemView to find MenuItemViews.
   set_id(kMenuItemViewID);
   has_icons_ = false;
+  lifecycle_observer_ = NULL;
 
   // Don't request enabled status from the root menu item as it is just
   // a container for real items.  EMPTY items will be disabled.
   MenuDelegate* root_delegate = GetDelegate();
   if (parent && type != EMPTY && root_delegate)
     SetEnabled(root_delegate->IsCommandEnabled(command));
 }
 
 void MenuItemView::PrepareForRun(bool is_first_menu,
                                  bool has_mnemonics,
@@ skipping 406 matching lines @@
     } else {
       const Type& type = menu_item->GetType();
       if (type == CHECKBOX || type == RADIO)
         return true;
     }
   }
   return false;
 }
 
 }  // namespace views