Add notification mechanism when BrowserActionButton's icon has been updated.

ui/views/controls/menu/menu_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_item_view.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_resources.h"
@@ skipping 89 matching lines @@
       has_mnemonics_(false),
       show_mnemonics_(false),
       has_icons_(false),
       icon_view_(NULL),
       top_margin_(-1),
       bottom_margin_(-1),
       left_icon_margin_(0),
       right_icon_margin_(0),
       requested_menu_position_(POSITION_BEST_FIT),
       actual_menu_position_(requested_menu_position_),
-      use_right_margin_(true) {
+      use_right_margin_(true),
+      lifecycle_observer_(NULL) {
   // NOTE: don't check the delegate for NULL, UpdateMenuPartSizes() supplies a
   // NULL delegate.
   Init(NULL, 0, SUBMENU, delegate);
 }
 
 void MenuItemView::ChildPreferredSizeChanged(View* child) {
   invalidate_dimensions();
   PreferredSizeChanged();
 }
 
@@ skipping 431 matching lines @@
   invalidate_dimensions();
 }
 
 const MenuConfig& MenuItemView::GetMenuConfig() const {
   const MenuController* controller = GetMenuController();
   if (controller)
     return controller->menu_config_;
   return MenuConfig::instance(NULL);
 }
 
 MenuItemView::MenuItemView(MenuItemView* parent,

[Finnur, 2014/02/12 11:19:52]

Can you add a comment saying:
// Note: This class also has a protected constructor and a common Init function
// to initialize both.

                            int command,
                            MenuItemView::Type type)
     : delegate_(NULL),
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(parent),
       type_(type),
       selected_(false),
       command_(command),
       submenu_(NULL),
       has_mnemonics_(false),
       show_mnemonics_(false),
       has_icons_(false),
       icon_view_(NULL),
       top_margin_(-1),
       bottom_margin_(-1),
       left_icon_margin_(0),
       right_icon_margin_(0),
       requested_menu_position_(POSITION_BEST_FIT),
       actual_menu_position_(requested_menu_position_),
       use_right_margin_(true) {
   Init(parent, command, type, NULL);
 }
 
 MenuItemView::~MenuItemView() {
   delete submenu_;
   STLDeleteElements(&removed_items_);
+  if (lifecycle_observer_)
+    lifecycle_observer_->OnDeleted(this);
 }
 
 const char* MenuItemView::GetClassName() const {
   return kViewClassName;
 }
 
 // Calculates all sizes that we can from the OS.
 //
 // This is invoked prior to Running a menu.
 void MenuItemView::UpdateMenuPartSizes() {
@@ skipping 18 matching lines @@
   label_start_ += padding;
 
   if (config.render_gutter)
     label_start_ += config.gutter_width + config.gutter_to_label;
 
   EmptyMenuMenuItem menu_item(this);
   menu_item.set_controller(GetMenuController());
   pref_menu_height_ = menu_item.GetPreferredSize().height();
 }
 
 void MenuItemView::Init(MenuItemView* parent,

[Finnur, 2014/02/12 11:19:52]

Can you add a comment saying:
// Note: This class also has a public constructor and a common Init function
// to initialize both.

                         int command,
                         MenuItemView::Type type,
                         MenuDelegate* delegate) {
   delegate_ = delegate;
   controller_ = NULL;
   canceled_ = false;
   parent_menu_item_ = parent;
   type_ = type;
   selected_ = false;
   command_ = command;
@@ skipping 421 matching lines @@
     } else {
       const Type& type = menu_item->GetType();
       if (type == CHECKBOX || type == RADIO)
         return true;
     }
   }
   return false;
 }
 
 }  // namespace views