Add notification mechanism when BrowserActionButton's icon has been updated.

ui/views/controls/menu/menu_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_item_view.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_resources.h"
@@ skipping 569 matching lines @@
       right_icon_margin_(0),
       requested_menu_position_(POSITION_BEST_FIT),
       actual_menu_position_(requested_menu_position_),
       use_right_margin_(true) {
   Init(parent, command, type, NULL);
 }
 
 MenuItemView::~MenuItemView() {
   delete submenu_;
   STLDeleteElements(&removed_items_);
+  if (lifecycle_observer_) {
+    lifecycle_observer_->OnDeleted(this);
+  }

[Finnur, 2014/02/10 10:41:41]

nit: When the body of an if clause is only 1 line (and there is 0-1 lines in the
else clause) then we omit the braces.

 }
 
 const char* MenuItemView::GetClassName() const {
   return kViewClassName;
 }
 
 // Calculates all sizes that we can from the OS.
 //
 // This is invoked prior to Running a menu.
 void MenuItemView::UpdateMenuPartSizes() {
@@ skipping 34 matching lines @@
   canceled_ = false;
   parent_menu_item_ = parent;
   type_ = type;
   selected_ = false;
   command_ = command;
   submenu_ = NULL;
   show_mnemonics_ = false;
   // Assign our ID, this allows SubmenuItemView to find MenuItemViews.
   set_id(kMenuItemViewID);
   has_icons_ = false;
+  lifecycle_observer_ = NULL;

[Finnur, 2014/02/10 10:41:41]

Looks like the convention in this class is to null in the initializer list for
the constructor (line 583).

[Finnur, 2014/02/12 11:19:52]

Hmmm... Now that I look at this again I realize this class has two constructors,
and we are now only updating one. Both need to make sure the lifecycle_observer_
start out as NULL so maybe I was wrong to ask you to move this to the ctor.

 
   // Don't request enabled status from the root menu item as it is just
   // a container for real items.  EMPTY items will be disabled.
   MenuDelegate* root_delegate = GetDelegate();
   if (parent && type != EMPTY && root_delegate)
     SetEnabled(root_delegate->IsCommandEnabled(command));
 }
 
 void MenuItemView::PrepareForRun(bool is_first_menu,
                                  bool has_mnemonics,
@@ skipping 406 matching lines @@
     } else {
       const Type& type = menu_item->GetType();
       if (type == CHECKBOX || type == RADIO)
         return true;
     }
   }
   return false;
 }
 
 }  // namespace views