Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1481423002: Oilpan: initialize stack allocated raw pointers following r362079. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: initialize stack allocated raw pointers following r362079. TBR=oilpan-reviews BUG=499780 NOTRY=true Committed: https://crrev.com/644ec7cd3edc2c399f94ebe798dc7864bb5f3d20 Cr-Commit-Position: refs/heads/master@{#362109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
While here, initialized all such RawPtr<> allocations in this code -- this is the convention ...
5 years ago (2015-11-30 08:58:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481423002/1
5 years ago (2015-11-30 08:59:04 UTC) #3
sof
oh, forgot to say...addresses failures http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan/builds/8765
5 years ago (2015-11-30 08:59:16 UTC) #4
haraken
LGTM
5 years ago (2015-11-30 08:59:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 09:07:21 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 09:07:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/644ec7cd3edc2c399f94ebe798dc7864bb5f3d20
Cr-Commit-Position: refs/heads/master@{#362109}

Powered by Google App Engine
This is Rietveld 408576698