Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 1481403006: tools/gn: make use of base's StartsWith() function (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: make use of base's StartsWith() function Since Brett introduced this funtion to base, we can make use of it and remove our copy from gn. We are also making use of it in other five files already. BUG=None TEST=gn gen + gn_unittests R=scottmg@chromium.org Committed: https://crrev.com/934d88d64c50f9f4d684194320cf15cd9b29059e Cr-Commit-Position: refs/heads/master@{#362446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M tools/gn/c_include_iterator.cc View 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
5 years ago (2015-12-01 09:23:52 UTC) #1
scottmg
lgtm
5 years ago (2015-12-01 16:42:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481403006/1
5 years ago (2015-12-01 17:34:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 17:41:12 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 17:42:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/934d88d64c50f9f4d684194320cf15cd9b29059e
Cr-Commit-Position: refs/heads/master@{#362446}

Powered by Google App Engine
This is Rietveld 408576698