net/dns/dns_test_util.cc - Issue 1481403005: Fix size_t truncations in net for 64-bit VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_test_util.cc

Issue 1481403005: Fix size_t truncations in net for 64-bit VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/dns_test_util.cc

diff --git a/net/dns/dns_test_util.cc b/net/dns/dns_test_util.cc

index 08c1f9246d7fbf850d625b00b97d006c70daeba2..6b2bdfb594957b55622655b45925600753aea189 100644

--- a/net/dns/dns_test_util.cc

+++ b/net/dns/dns_test_util.cc

@@ -122,7 +122,7 @@ class MockTransaction : public DnsTransaction,

writer.WriteU16(qtype_);

writer.WriteU16(dns_protocol::kClassIN);

writer.WriteU32(kTTL);

- writer.WriteU16(rdata_size);

+ writer.WriteU16(static_cast<uint16>(rdata_size));

if (qtype_ == dns_protocol::kTypeA) {

char kIPv4Loopback[] = { 0x7f, 0, 0, 1 };

writer.WriteBytes(kIPv4Loopback, sizeof(kIPv4Loopback));

« no previous file with comments | « no previous file | net/quic/congestion_control/tcp_loss_algorithm_test.cc » ('j') | no next file with comments »