Fix size_t truncations in net for 64-bit VS 2015

net/socket/socks5_client_socket_unittest.cc

Index: net/socket/socks5_client_socket_unittest.cc
diff --git a/net/socket/socks5_client_socket_unittest.cc b/net/socket/socks5_client_socket_unittest.cc
index 76146c7ab83e959bc4998e18cc2ab10412789a83..bec8848002fa3ff5043e4c9546677428a0de3aa3 100644
--- a/net/socket/socks5_client_socket_unittest.cc
+++ b/net/socket/socks5_client_socket_unittest.cc
@@ -194,7 +194,7 @@ TEST_F(SOCKS5ClientSocketTest, ConnectAndDisconnectTwice) {
   };
 
   std::string request(kSOCKS5DomainRequest, arraysize(kSOCKS5DomainRequest));
-  request.push_back(hostname.size());
+  request.push_back(base::checked_cast<char>(hostname.size()));

[Ryan Sleevi, 2015/12/01 01:25:58]

This is a test - shouldn't it just be static?

[brucedawson, 2015/12/01 01:33:45]

My assumption was that tests are the awesomest place for checked_cast because we
don't need to worry about the code-size tradeoffs so we can even-more ruthlessly
expose bugs.

[Ryan Sleevi, 2015/12/01 01:44:17]

Because line 188 makes it 'obviously correct', and you seemed to omit it for the
other tests that were similarly obviously correct :)

   request.append(hostname);
   request.append(reinterpret_cast<const char*>(&kNwPort), sizeof(kNwPort));