Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1481383005: Fix typo in V8.GCFinalizeMC. (Closed)

Created:
5 years ago by ulan
Modified:
5 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in V8.GCFinalizeMC. BUG= Committed: https://crrev.com/77a20f607581e7842d7ce2473800de29720eddbd Cr-Commit-Position: refs/heads/master@{#363037}

Patch Set 1 #

Patch Set 2 : Mark the old histogram as obsolete #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
ulan
PTAL The real change is V8.GCFinalzeMC => V8.GCFinalizeMC. The rest is done by the formatting ...
5 years ago (2015-12-01 13:45:48 UTC) #3
Mark P
I see from code search ( https://codereview.chromium.org/1419833002/diff/1/src/counters.h ) that the histogram with the wrong name ...
5 years ago (2015-12-01 18:41:19 UTC) #4
ulan
On 2015/12/01 18:41:19, Mark P wrote: > I see from code search ( > https://codereview.chromium.org/1419833002/diff/1/src/counters.h ...
5 years ago (2015-12-02 08:35:33 UTC) #5
Mark P
lgtm
5 years ago (2015-12-02 18:27:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383005/20001
5 years ago (2015-12-03 08:43:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/102379)
5 years ago (2015-12-03 10:54:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383005/20001
5 years ago (2015-12-03 11:00:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/102448)
5 years ago (2015-12-03 13:03:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383005/40001
5 years ago (2015-12-03 18:28:48 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 19:53:01 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-03 19:53:45 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77a20f607581e7842d7ce2473800de29720eddbd
Cr-Commit-Position: refs/heads/master@{#363037}

Powered by Google App Engine
This is Rietveld 408576698