|
|
DescriptionFix typo in V8.GCFinalizeMC.
BUG=
Committed: https://crrev.com/77a20f607581e7842d7ce2473800de29720eddbd
Cr-Commit-Position: refs/heads/master@{#363037}
Patch Set 1 #Patch Set 2 : Mark the old histogram as obsolete #Patch Set 3 : rebase #Messages
Total messages: 21 (10 generated)
Description was changed from ========== Fix typo in V8.GCFinalizeMC. BUG= ========== to ========== Fix typo in V8.GCFinalizeMC. BUG= ==========
ulan@chromium.org changed reviewers: + hpayer@chromium.org, mpearson@chromium.org
PTAL The real change is V8.GCFinalzeMC => V8.GCFinalizeMC. The rest is done by the formatting tool.
I see from code search ( https://codereview.chromium.org/1419833002/diff/1/src/counters.h ) that the histogram with the wrong name was actually being recorded, and then you corrected the name. In that case, you need to keep the wrong-name histogram in histograms.xml and mark it as obsolete. --mark
On 2015/12/01 18:41:19, Mark P wrote: > I see from code search ( > https://codereview.chromium.org/1419833002/diff/1/src/counters.h ) that the > histogram with the wrong name was actually being recorded, and then you > corrected the name. In that case, you need to keep the wrong-name histogram in > histograms.xml and mark it as obsolete. > > --mark Thanks, done. I uploaded new PS.
lgtm
The CQ bit was checked by ulan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by ulan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by ulan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/1481383005/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383005/40001
Message was sent while issue was closed.
Description was changed from ========== Fix typo in V8.GCFinalizeMC. BUG= ========== to ========== Fix typo in V8.GCFinalizeMC. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix typo in V8.GCFinalizeMC. BUG= ========== to ========== Fix typo in V8.GCFinalizeMC. BUG= Committed: https://crrev.com/77a20f607581e7842d7ce2473800de29720eddbd Cr-Commit-Position: refs/heads/master@{#363037} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/77a20f607581e7842d7ce2473800de29720eddbd Cr-Commit-Position: refs/heads/master@{#363037} |