Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1481383004: Revert of [heap] Remove live weak cells from weak cell list when finalizing incremental marking. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove live weak cells from weak cell list when finalizing incremental marking. (patchset #3 id:40001 of https://codereview.chromium.org/1474303002/ ) Reason for revert: Still investigating bad canary. Original issue's description: > [heap] Remove live weak cells from weak cell list when finalizing incremental marking. > > BUG=chromium:548562 > LOG=n > > Committed: https://crrev.com/6190c608c8f3ced0f00ff53965e115b78646cecd > Cr-Commit-Position: refs/heads/master@{#32372} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:548562 Committed: https://crrev.com/72ae472ccc51ec304a66a8730c1fedbe265c16fa Cr-Commit-Position: refs/heads/master@{#32459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M src/heap/incremental-marking.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Remove live weak cells from weak cell list when finalizing incremental ...
5 years ago (2015-12-01 13:26:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481383004/1
5 years ago (2015-12-01 13:26:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 13:27:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72ae472ccc51ec304a66a8730c1fedbe265c16fa Cr-Commit-Position: refs/heads/master@{#32459}
5 years ago (2015-12-01 13:27:24 UTC) #6
Hannes Payer (out of office)
5 years ago (2015-12-02 11:06:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1491743003/ by hpayer@chromium.org.

The reason for reverting is: Reland after fixing the potential root cause of the
canary crasher..

Powered by Google App Engine
This is Rietveld 408576698