Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Issue 1481353002: X87: [runtime] Replace global object link with native context link in all contexts. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Replace global object link with native context link in all contexts. port 47502a238b8185a864bfe6a8d5508b4e67cad40e (r32381) original commit message: Previously all contexts had a link to the global object, but what is required in most cases (except for the global load, store and delete case) is the native context. This also removes the second dummy global object that was still linked to every native context. We will add a different mechanism to ensure that builtins do not pollute the actual global object during bootstrapping. Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff. BUG= Committed: https://crrev.com/55480ba30e9ab75a34076f24caf998bce62a7c28 Cr-Commit-Position: refs/heads/master@{#32387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -50 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 7 chunks +14 lines, -12 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 5 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-11-30 04:15:37 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-30 04:20:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481353002/1
5 years ago (2015-11-30 04:20:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 04:37:33 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 04:37:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55480ba30e9ab75a34076f24caf998bce62a7c28
Cr-Commit-Position: refs/heads/master@{#32387}

Powered by Google App Engine
This is Rietveld 408576698